Allow custom descriptions for self-nesting reuses#1366
Merged
kgeller merged 13 commits intoelastic:masterfrom Apr 20, 2021
kgeller:custom-descriptions-for-self-nesting
Merged
Allow custom descriptions for self-nesting reuses#1366kgeller merged 13 commits intoelastic:masterfrom kgeller:custom-descriptions-for-self-nesting
kgeller merged 13 commits intoelastic:masterfrom
kgeller:custom-descriptions-for-self-nesting
Conversation
…ller/ecs into custom-descriptions-for-self-nesting
ebeahan
reviewed
Apr 20, 2021
Co-authored-by: Eric Beahan <ebeahan@gmail.com>
ebeahan
approved these changes
Apr 20, 2021
Member
ebeahan
left a comment
There was a problem hiding this comment.
LGTM 👍
I see some other cases of text wrapping even after switching the header to Field Set, but I don't think we should hold off on introducing these changes. We can iterate on it in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to override a short description when self nesting fields. Also, a small tweak to the ascii docs tables, for a third column to capture the field being nested.