This repository was archived by the owner on Sep 17, 2024. It is now read-only.
chore: tag docker image after loading it from a file#772
Merged
mdelapenya merged 1 commit intoelastic:masterfrom Feb 18, 2021
Merged
chore: tag docker image after loading it from a file#772mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya merged 1 commit intoelastic:masterfrom
Conversation
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
mdelapenya
commented
Feb 18, 2021
| WithArch(arch). | ||
| WithArtifact(artifact). | ||
| WithOS(os). | ||
| WithVersion(e2e.CheckPRVersion(version, agentVersionBase)) // sanitize version |
Contributor
Author
There was a problem hiding this comment.
We will sanitize the version internally, see https://github.com/elastic/e2e-testing/pull/772/files#diff-d92db9d0c3d8b8a143e834b73bdfbcd816f191b556ae6439985409c475b58cd4R193-R194
cachedout
approved these changes
Feb 18, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Feb 18, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Feb 18, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Feb 18, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Feb 18, 2021
This was referenced Feb 18, 2021
mdelapenya
added a commit
that referenced
this pull request
Feb 18, 2021
mdelapenya
added a commit
that referenced
this pull request
Feb 18, 2021
mdelapenya
added a commit
that referenced
this pull request
Feb 18, 2021
mdelapenya
added a commit
that referenced
this pull request
Feb 18, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It uses the Go Docker client to tag the imported image with the original version as tag.
Why is it important?
We noticed the e2e are downloading the right binary from GCP (always
AMD64), BUT the docker load command creates the new image without the proper tag, usingagent:8.0.0-SNAPSHOTinstead ofagent:pr-12345. Again but, the docker-compose file requires the second one, so it looks up theobservability-cinamespace in the Docker registry, not honouring the physical file that was downloaded and imported, pullingagent:pr-12345instead.Checklist
make noticein the proper directory)Author's Checklist
How to test this PR locally
Related issues
Logs
Follow-ups