chore: properly evaluate how tests are skipped on CI when checking modified files by mdelapenya · Pull Request #1924 · elastic/e2e-testing

mdelapenya · 2021-12-17T11:04:04Z

What does this PR do?

This PR does two things:

wraps the evaluation of the stack deployment stage in an anyOf block, so that is consistent with all other stages.
extracts the logic to evaluate if the tests must be skipped to a single function. This function starts setting the SKIP_TESTS env var to false, and:

if there are only markdown files in the changeset, the it will set the env var SKIP_TESTS to true.
if the changeset contains at least one modified file matching certain paths (see the modified files in this PR), then it will set the SKIP_TESTS env var to false.

Why is it important?

The unit tests stage is constantly skipped.

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have run the Unit tests (make unit-test), and they are passing locally
I have run the End-2-End tests for the suite I'm working on, and they are passing locally
I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

Fixes Unit test stage is always skipped with "Waiting for run to start" #1915

elasticmachine · 2021-12-17T11:44:16Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-12-17T12:36:21.558+0000
Duration: 36 min 41 sec
Commit: 2c73677

Test stats 🧪

Test	Results
Failed	0
Passed	216
Skipped	0
Total	216

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

.ci/Jenkinsfile

v1v · 2021-12-17T12:03:20Z

.ci/Jenkinsfile

-                def regexps = [ "^e2e/_suites/fleet/.*", "^e2e/_suites/helm/.*", "^e2e/_suites/kubernetes-autodiscover/.*", "^.ci/.*", "^cli/.*", "^e2e/.*\\.go", "^internal/.*\\.go" ]
-                setEnvVar("SKIP_TESTS", !isGitRegionMatch(patterns: regexps, shouldMatchAll: false))
-              }
+            script {


NIT:
IIRC, this unrequired when running a method

yep, not needed

.ci/Jenkinsfile

v1v

My comments are NIT

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

.ci/Jenkinsfile

…dified files (#1924) * chore: consistency * chore: refactor how the evaluation of the skip_tests is done * chore: use proper function name * chore: remove non needed initialisation Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> * chore: call method without script block Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> (cherry picked from commit e438b87)

…dified files (#1924) (#1925) * chore: consistency * chore: refactor how the evaluation of the skip_tests is done * chore: use proper function name * chore: remove non needed initialisation Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> * chore: call method without script block Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> (cherry picked from commit e438b87) Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>

…dified files (#1924) (#1927) * chore: consistency * chore: refactor how the evaluation of the skip_tests is done * chore: use proper function name * chore: remove non needed initialisation Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> * chore: call method without script block Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> (cherry picked from commit e438b87) Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>

…dified files (#1924) (#1926) * chore: consistency * chore: refactor how the evaluation of the skip_tests is done * chore: use proper function name * chore: remove non needed initialisation Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> * chore: call method without script block Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> (cherry picked from commit e438b87) Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>

* main: (45 commits) feat: add CentOS 8 support (elastic#2034) fix: set default region for AWS cli (elastic#2053) chore: use Ansible's built-in replace instead of sed (elastic#2048) chore: split stack configuration and start into two tasks (elastic#2044) feat: enable SSH access to users for debugging cloud instances (elastic#2001) fix: use the right branch for 7.17 backports (elastic#2025) SLES15 enablement (elastic#2007) chore: bump stale agent for main (elastic#2014) Update `fetchBeatsBinary` to be reused in elastic-agent-poc (elastic#1984) chore: add resiliency when provisioning the stack (elastic#1990) chore: bump elastic-package to v0.32.1 (elastic#1959) feat: export Fetch&Download methods in the /pkg directory (elastic#1943) bump stack version 8.1.0-dbc834fd (elastic#1948) bump stack version 8.1.0-76902d39 (elastic#1946) chore: retire 7.15 adding 7.17 (elastic#1938) ci: use withAPMEnv (elastic#1917) Update main branch (elastic#1928) bump stack version 8.1.0-befff95a (elastic#1929) chore: properly evaluate how tests are skipped on CI when checking modified files (elastic#1924) bump stack version 8.1.0-60bffc32 (elastic#1921) ...

* main: chore: retire 7.15 adding 7.17 (elastic#1938) ci: use withAPMEnv (elastic#1917) Update main branch (elastic#1928) bump stack version 8.1.0-befff95a (elastic#1929) chore: properly evaluate how tests are skipped on CI when checking modified files (elastic#1924) bump stack version 8.1.0-60bffc32 (elastic#1921) fix: add resiliency when an integration cannot be added to a policy (elastic#1914)

mdelapenya added 2 commits December 17, 2021 11:25

chore: consistency

1b781c0

chore: refactor how the evaluation of the skip_tests is done

ccbb0a8

mdelapenya added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify labels Dec 17, 2021

mdelapenya self-assigned this Dec 17, 2021

mdelapenya requested a review from a team December 17, 2021 11:04

mdelapenya marked this pull request as ready for review December 17, 2021 11:24

mdelapenya commented Dec 17, 2021

View reviewed changes

.ci/Jenkinsfile Outdated Show resolved Hide resolved

.ci/Jenkinsfile Outdated Show resolved Hide resolved

chore: use proper function name

b0fc295

v1v reviewed Dec 17, 2021

View reviewed changes

v1v approved these changes Dec 17, 2021

View reviewed changes

kuisathaverat approved these changes Dec 17, 2021

View reviewed changes

chore: remove non needed initialisation

ab3f4c1

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>

mdelapenya commented Dec 17, 2021

View reviewed changes

.ci/Jenkinsfile Outdated Show resolved Hide resolved

chore: call method without script block

2c73677

mdelapenya merged commit e438b87 into elastic:master Dec 17, 2021

mergify bot mentioned this pull request Dec 17, 2021

[8.0](backport #1924) chore: properly evaluate how tests are skipped on CI when checking modified files #1925

Merged

mergify bot mentioned this pull request Dec 17, 2021

[7.16](backport #1924) chore: properly evaluate how tests are skipped on CI when checking modified files #1926

Merged

mergify bot mentioned this pull request Dec 17, 2021

[7.15](backport #1924) chore: properly evaluate how tests are skipped on CI when checking modified files #1927

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: properly evaluate how tests are skipped on CI when checking modified files#1924

chore: properly evaluate how tests are skipped on CI when checking modified files#1924
mdelapenya merged 5 commits intoelastic:masterfrom
mdelapenya:fix-ci-unit-tests

mdelapenya commented Dec 17, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Dec 17, 2021 •

edited

Loading

Build stats

Test stats 🧪

Uh oh!

Uh oh!

Uh oh!

v1v Dec 17, 2021

Uh oh!

kuisathaverat Dec 17, 2021

Uh oh!

Uh oh!

v1v left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mdelapenya commented Dec 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Related issues

Uh oh!

elasticmachine commented Dec 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

Uh oh!

Uh oh!

Uh oh!

v1v Dec 17, 2021

Choose a reason for hiding this comment

Uh oh!

kuisathaverat Dec 17, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

v1v left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mdelapenya commented Dec 17, 2021 •

edited

Loading

elasticmachine commented Dec 17, 2021 •

edited

Loading