This repository was archived by the owner on Sep 17, 2024. It is now read-only.
Merged
Conversation
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
adam-stokes
approved these changes
Oct 12, 2021
mdelapenya
reviewed
Oct 13, 2021
| script { | ||
| def suitesParam = params.runTestsSuites | ||
| def existingSuites = readYaml(file: '.ci/.e2e-tests.yaml') | ||
| def existingSuites = readYaml(file: "${TEST_MATRIX_FILE}") |
Contributor
There was a problem hiding this comment.
Super smart!!
This will allow the simplification of the way we select the test suite to run: instead of the runTestSuites param, we could simply create "profiles" as you created here, and select the entire profile instead of evaluating the previous param.
mdelapenya
approved these changes
Oct 13, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2021
(cherry picked from commit 73093f6)
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2021
(cherry picked from commit 73093f6)
v1v
pushed a commit
that referenced
this pull request
Oct 13, 2021
mdelapenya
pushed a commit
that referenced
this pull request
Oct 15, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow to customise the pipeline with the file that contains the suites and scenarios
Why is it important?
Allow to define different suites/scenarios in files. elastic/beats#24112 (review) could benefit from, for instance, if we enable the e2e-testing as part of the process in the Beats main pipeline, then we can start with supporting a minimal subset and then incrementally add more scenarios.