Add autodiscover 2e2 testcases for Agent (standalone) by ChrsMark · Pull Request #1645 · elastic/e2e-testing

ChrsMark · 2021-10-07T11:31:22Z

What does this PR do?

This PR adds autodiscover test cases for elastic-agent standalone.

Why is it important?

To cover autodiscover in Agent with 2e2 tests.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have run the Unit tests (make unit-test), and they are passing locally
I have run the End-2-End tests for the suite I'm working on, and they are passing locally
I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

Closes Add Kubernetes autodiscover test cases for standalone Agent #1090

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

mergify · 2021-10-07T11:31:37Z

This pull request is now in conflict. Could you fix it @ChrsMark? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b add_agent_autodiscovery_cases upstream/add_agent_autodiscovery_cases
git merge upstream/master
git push upstream add_agent_autodiscovery_cases

…covery_cases

elasticmachine · 2021-10-07T13:28:55Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-10-15T09:30:43.036+0000
Duration: 34 min 14 sec
Commit: e334b2d

Test stats 🧪

Test	Results
Failed	0
Passed	238
Skipped	0
Total	238

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

mdelapenya · 2021-10-07T14:48:16Z

e2e/_suites/kubernetes-autodiscover/features/elastic-agent.feature

@@ -0,0 +1,9 @@
+@kubernetes-autodiscover
+@elastic-agent
+Feature: elastic-agent standalone


It's awesome you had to write NO Go code to implement a scenario!

mdelapenya · 2021-10-07T14:54:14Z

@ChrsMark thanks for your first contribution to the project! It is indeed great!

I'm only missing one change to add the new scenarios. As explained in the docs (https://github.com/elastic/e2e-testing/tree/master/e2e#feature-files-and-the-ci) the CI will use the .ci/.e2e-tests.yaml file to spread the feature files on the parallel CI workers. Simply using this block will do the trick:

  - suite: "kubernetes-autodiscover"
    platforms:
      - labels: "ubuntu-18.04"
    scenarios:
      - name: "kubernetes autodiscover with elastic-agent"
        tags: "kubernetes-autodiscover && elastic-agent"
      - name: "kubernetes autodiscover with filebeat"
        tags: "kubernetes-autodiscover && filebeat"
      - name: "kubernetes autodiscover with heartbeat"
        tags: "kubernetes-autodiscover && heartbeat"
      - name: "kubernetes autodiscover with metricbeat"
        tags: "kubernetes-autodiscover && metricbeat"

mdelapenya

Only missing what described in #1645 (comment).

Once there, I'd merge this one :)

mdelapenya · 2021-10-08T05:41:18Z

One last question: could you please add labels for backports?

v7.16.0 label -> 7.x branch
v7.15.0 label -> 7.15.x branch
v7.14.0 label -> 7.14.x branch

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

ChrsMark · 2021-10-11T13:51:17Z

I wonder what makes it failing on the CI while it works locally 🤔

e2e/_suites/kubernetes-autodiscover/features/elastic-agent.feature

e2e/_suites/kubernetes-autodiscover/testdata/templates/elastic-agent.yml.tmpl

mdelapenya · 2021-10-11T14:52:02Z

I wonder what makes it failing on the CI while it works locally 🤔

I'm manually running the CI using TRACE log level: https://beats-ci.elastic.co/job/e2e-tests/job/e2e-testing-mbp/job/PR-1645/7/. Let's check if that error is repeatable

mdelapenya · 2021-10-11T15:41:18Z

@ChrsMark it passed, although the single failure that is currently present (windows related) is considered flaky.

https://beats-ci.elastic.co/blue/organizations/jenkins/e2e-tests%2Fe2e-testing-mbp/detail/PR-1645/7/pipeline/226

I'd say this is LGTM

…ture Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>

…-agent.yml.tmpl Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>

ChrsMark · 2021-10-12T07:26:47Z

Thanks for reviewing @mdelapenya ! After applying your suggestions the k8s suite failed again and I'm not sure I can understand the reason. I'm particularly concerned of introducing some flakiness here so could you spot where it fails when this happen?

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

mdelapenya

LGTM 👍

mdelapenya · 2021-10-15T10:15:06Z

@ChrsMark this is ready to go, merging!

* Add initial case Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Add go dep Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Add go dep Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Review changes and more tests Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Add more cases Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Add extra case Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Update e2e/_suites/kubernetes-autodiscover/features/elastic-agent.feature Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> * Update e2e/_suites/kubernetes-autodiscover/testdata/templates/elastic-agent.yml.tmpl Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> * Fix scope of cronjob test Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * chore: fix go fmt * chore: do not destroy kind cluster in DEV mode Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com> (cherry picked from commit a23b3b4)

jsoriano · 2021-10-15T10:18:10Z

❤️ thanks!

Add initial case

8bae59c

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

ChrsMark added the Team:Integrations Label for the Integrations team label Oct 7, 2021

ChrsMark self-assigned this Oct 7, 2021

ChrsMark mentioned this pull request Oct 7, 2021

Add Kubernetes autodiscover test cases for standalone Agent #1090

Closed

Merge remote-tracking branch 'upstream/master' into add_agent_autodis…

0a79201

…covery_cases

ChrsMark added 2 commits October 7, 2021 16:57

Add go dep

25e092c

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Add go dep

790ebbd

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

mdelapenya reviewed Oct 7, 2021

View reviewed changes

mdelapenya suggested changes Oct 8, 2021

View reviewed changes

ChrsMark added v7.16.0 v7.15.0 and removed v7.15.0 labels Oct 11, 2021

ChrsMark added 3 commits October 11, 2021 13:30

Review changes and more tests

f0ac33e

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Add more cases

9f6f212

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

Add extra case

9f53a87

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

ChrsMark requested a review from mdelapenya October 11, 2021 12:29

mdelapenya reviewed Oct 11, 2021

View reviewed changes

e2e/_suites/kubernetes-autodiscover/features/elastic-agent.feature Outdated Show resolved Hide resolved

mdelapenya reviewed Oct 11, 2021

View reviewed changes

e2e/_suites/kubernetes-autodiscover/testdata/templates/elastic-agent.yml.tmpl Outdated Show resolved Hide resolved

ChrsMark and others added 2 commits October 11, 2021 23:47

Update e2e/_suites/kubernetes-autodiscover/features/elastic-agent.fea…

fbbabfd

…ture Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>

Update e2e/_suites/kubernetes-autodiscover/testdata/templates/elastic…

3905b9d

…-agent.yml.tmpl Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>

ChrsMark requested a review from mdelapenya October 14, 2021 07:10

Merge branch 'master' into add_agent_autodiscovery_cases

1a2024a

ChrsMark and others added 3 commits October 15, 2021 12:14

Fix scope of cronjob test

e6e2c5d

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>

chore: fix go fmt

6136154

chore: do not destroy kind cluster in DEV mode

e334b2d

mdelapenya approved these changes Oct 15, 2021

View reviewed changes

mdelapenya merged commit a23b3b4 into elastic:master Oct 15, 2021

mergify bot mentioned this pull request Oct 15, 2021

[7.x](backport #1645) Add autodiscover 2e2 testcases for Agent (standalone) #1656

Merged

ChrsMark pushed a commit that referenced this pull request Oct 15, 2021

Add autodiscover 2e2 testcases for Agent (standalone) (#1645) (#1656)

96c049d

This was referenced Oct 15, 2021

chore: skip install scenario on windows #1659

Merged

fix: use snake case for feature files #1663

Merged

[7.15](backport #1690) feat: export Kind cluster logs #1709

Merged

[7.14](backport #1690) feat: export Kind cluster logs #1710

Merged

mdelapenya mentioned this pull request Oct 26, 2021

chore: bump elastic-package to v0.25.0 #1721

Merged

8 tasks

Conversation

ChrsMark commented Oct 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Related issues

Uh oh!

mergify bot commented Oct 7, 2021

Uh oh!

elasticmachine commented Oct 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

Uh oh!

mdelapenya Oct 7, 2021

Choose a reason for hiding this comment

Uh oh!

mdelapenya commented Oct 7, 2021

Uh oh!

mdelapenya left a comment

Choose a reason for hiding this comment

Uh oh!

mdelapenya commented Oct 8, 2021

Uh oh!

ChrsMark commented Oct 11, 2021

Uh oh!

Uh oh!

Uh oh!

mdelapenya commented Oct 11, 2021

Uh oh!

mdelapenya commented Oct 11, 2021

Uh oh!

ChrsMark commented Oct 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdelapenya left a comment

Choose a reason for hiding this comment

Uh oh!

mdelapenya commented Oct 15, 2021

Uh oh!

jsoriano commented Oct 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ChrsMark commented Oct 7, 2021 •

edited

Loading

elasticmachine commented Oct 7, 2021 •

edited

Loading

ChrsMark commented Oct 12, 2021 •

edited

Loading