Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

fix: run linux integration on CI#1186

Merged
mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya:run-linux-integration
May 19, 2021
Merged

fix: run linux integration on CI#1186
mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya:run-linux-integration

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya commented May 19, 2021

What does this PR do?

It includes the linux integration scenarios in the CI job, as a new parallel branch

Why is it important?

This suite was missing from CI execution

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

@mdelapenya mdelapenya self-assigned this May 19, 2021
@mdelapenya mdelapenya requested a review from a team May 19, 2021 06:44
@mdelapenya mdelapenya marked this pull request as ready for review May 19, 2021 06:45
@mdelapenya mdelapenya requested a review from jalvz May 19, 2021 06:45
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1186 opened

  • Start Time: 2021-05-19T06:44:28.914+0000

  • Duration: 29 min 42 sec

  • Commit: 339d037

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 0
Total 160

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 0
Total 160

@jalvz
Copy link
Copy Markdown
Contributor

jalvz commented May 19, 2021

Shouldn't we do something so that every new scenario added is executed on CI without more ceremony? ie, have the option maybe to opt out in case it is useful, instead of having to opt in.

@mdelapenya
Copy link
Copy Markdown
Contributor Author

mdelapenya commented May 19, 2021 •
edited
Loading

Shouldn't we do something so that every new scenario added is executed on CI without more ceremony? ie, have the option maybe to opt out in case it is useful, instead of having to opt in.

Agree. There is an open issue to standardise the tags used in feature files, which could simplify how they are spread across the different parallel executions. I can picture this:

  1. list all feature files
  2. change how the Make goals run the tests: instead of the tags use the file (-f $THE_FEATURE_FILE)
  3. generate the descriptor file on the fly based on a template, using one feature file per parallel branch
  4. update calls to make goals to not pass tags

If this makes sense to you, we can convert this comment into a new issue to start working on it, as I totally agree with you about the ceremonies :)

@mdelapenya
Copy link
Copy Markdown
Contributor Author

mdelapenya commented May 19, 2021 •
edited
Loading

Another idea, related to the used tags, could be to group all integrations under the @integration tag, and run them all together: we'd have endpoint and linux integration under the same parallel execution on CI, but this will resolve this specific use case for the integrations.

@mdelapenya mdelapenya merged commit dc479f5 into elastic:master May 19, 2021
mergify bot pushed a commit that referenced this pull request May 19, 2021
@mdelapenya
fix: run linux integration on CI (#1186)
21ec6ec 
(cherry picked from commit dc479f5)
@mergify mergify bot mentioned this pull request May 19, 2021
Merged
mergify bot pushed a commit that referenced this pull request May 19, 2021
@mdelapenya
fix: run linux integration on CI (#1186)
f2cebd2 
(cherry picked from commit dc479f5)
@mergify mergify bot mentioned this pull request May 19, 2021
Merged
mergify bot pushed a commit that referenced this pull request May 19, 2021
@mdelapenya
fix: run linux integration on CI (#1186)
1b65813 
(cherry picked from commit dc479f5)
@mergify mergify bot mentioned this pull request May 19, 2021
Merged
mdelapenya added a commit that referenced this pull request May 19, 2021
@mergify @mdelapenya
fix: run linux integration on CI (#1186) (#1187)
8a2a5f1 
(cherry picked from commit dc479f5)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit that referenced this pull request May 19, 2021
@mergify @mdelapenya
fix: run linux integration on CI (#1186) (#1188)
47c27c4 
(cherry picked from commit dc479f5)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit that referenced this pull request May 19, 2021
@mergify @mdelapenya
fix: run linux integration on CI (#1186) (#1189)
3957f40 
(cherry picked from commit dc479f5)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
@mdelapenya mdelapenya deleted the run-linux-integration branch May 19, 2021 09:33
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request May 19, 2021
@mdelapenya
Merge branch 'master' into arm-suppport
84b93b4 
* master:
  fix: run linux integration on CI (elastic#1186)
  docs: document integrations in the proper README file (elastic#1181)
  fix: resolve issues in k8s-autodiscover test suite (elastic#1171)
  feat: make a stronger verification of fleet-server being bootstrapped (elastic#1164)
@jalvz
Copy link
Copy Markdown
Contributor

jalvz commented May 20, 2021

change how the Make goals run the tests: instead of the tags use the file (-f $THE_FEATURE_FILE)

could we be even a folder?

@mdelapenya
Copy link
Copy Markdown
Contributor Author

mdelapenya commented May 20, 2021 •
edited
Loading

change how the Make goals run the tests: instead of the tags use the file (-f $THE_FEATURE_FILE)

could we be even a folder?

Yes, or a glob expression: *.feature. but on CI we want to create a separation of concerns per feature, to speed up the build

@mdelapenya mdelapenya mentioned this pull request May 20, 2021
Closed
@mdelapenya mdelapenya mentioned this pull request Oct 26, 2021
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jalvz jalvz Awaiting requested review from jalvz

1 more reviewer

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdelapenya mdelapenya

Labels

v7.12.0 v7.13.0 v7.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdelapenya @elasticmachine @jalvz @kuisathaverat