Conversation
TBD on recipes. Most links are not complete and need updating from "???".
Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
PeteGillinElastic
left a comment
There was a problem hiding this comment.
This is looking good so far! I have one drive-by comment.
|
Hi @jbaiera I noticed a small issue This example Should be add the |
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left some comments, but nothing major. This is a monumental amount of work and I think it's great, thanks Jimmy.
|
@dakrone Any chance we might get this before FF for 8.19? We've made some work in the kibana UI and would be great if we can add a link to the docs |
There was a problem hiding this comment.
hey @jbaiera! just adding a couple of comments to address the metadata of these pages / improve wayfinding between the pages. also approving to make sure that you're unblocked. let me know if you need a hand with anything.
|
🔍 Preview links for changed docs:
🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
shainaraskas
left a comment
There was a problem hiding this comment.
to fix the failing test
…ream (#221644) Added a tooltip and a link with documentation for Failed docs column when dataset does not have failure store enabled. https://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e For now it awaits for the documentation PR to be merged : elastic/docs-content#1368 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
…ream (elastic#221644) Added a tooltip and a link with documentation for Failed docs column when dataset does not have failure store enabled. https://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e For now it awaits for the documentation PR to be merged : elastic/docs-content#1368 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co> (cherry picked from commit 36cbbb9)
…data stream (#221644) (#225007) # Backport This will backport the following commits from `main` to `8.19`: - [[Dataset Quality] Indicate if failure store isn't enabled for data stream (#221644)](#221644) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Stelmach","email":"60304951+rStelmach@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-24T07:49:36Z","message":"[Dataset Quality] Indicate if failure store isn't enabled for data stream (#221644)\n\nAdded a tooltip and a link with documentation for Failed docs column\nwhen dataset does not have failure store enabled.\n\n\n\nhttps://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e\n\n\n\n\nFor now it awaits for the documentation PR to be merged :\nhttps://github.com/elastic/docs-content/pull/1368\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Yngrid Coello <yngrid.coello@elastic.co>","sha":"36cbbb9bf8f141a54bb6c455e4479e93990d9626","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:feature","Feature:Dataset Health","backport:version","v9.1.0","v8.19.0"],"title":"[Dataset Quality] Indicate if failure store isn't enabled for data stream","number":221644,"url":"https://github.com/elastic/kibana/pull/221644","mergeCommit":{"message":"[Dataset Quality] Indicate if failure store isn't enabled for data stream (#221644)\n\nAdded a tooltip and a link with documentation for Failed docs column\nwhen dataset does not have failure store enabled.\n\n\n\nhttps://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e\n\n\n\n\nFor now it awaits for the documentation PR to be merged :\nhttps://github.com/elastic/docs-content/pull/1368\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Yngrid Coello <yngrid.coello@elastic.co>","sha":"36cbbb9bf8f141a54bb6c455e4479e93990d9626"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221644","number":221644,"mergeCommit":{"message":"[Dataset Quality] Indicate if failure store isn't enabled for data stream (#221644)\n\nAdded a tooltip and a link with documentation for Failed docs column\nwhen dataset does not have failure store enabled.\n\n\n\nhttps://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e\n\n\n\n\nFor now it awaits for the documentation PR to be merged :\nhttps://github.com/elastic/docs-content/pull/1368\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Yngrid Coello <yngrid.coello@elastic.co>","sha":"36cbbb9bf8f141a54bb6c455e4479e93990d9626"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Stelmach <60304951+rStelmach@users.noreply.github.com> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
…ream (elastic#221644) Added a tooltip and a link with documentation for Failed docs column when dataset does not have failure store enabled. https://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e For now it awaits for the documentation PR to be merged : elastic/docs-content#1368 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Yngrid Coello <yngrid.coello@elastic.co>
Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
Co-authored-by: shainaraskas <shainaraskas@users.noreply.github.com>
shainaraskas
left a comment
There was a problem hiding this comment.
removing links to anchors to get the PR green
Adds a new section to the documentation to explain new failure store functionality.
Preview:
https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/1368/manage-data/data-store/data-streams/failure-store
This PR relies on links to updates in: