Beats: add x-pack/filebeat/docs to contents#507
Beats: add x-pack/filebeat/docs to contents#507dedemorton merged 2 commits intoelastic:masterfrom adriansr:beats-xpack-docs
Conversation
This patch adds the x-pack/filebeat/docs to the list of directories to look for docs in Filebeat. This is needed so that we can include x-pack specific docs.
|
In case it makes a difference, we're slowly getting rid of that folder structure in the elasticsearch repo and have already removed it from kibana. The "x-pack" content is now just mixed in with the rest. |
|
My advice would be to leave the x-pack content in the regular docs folder, but if you do go this route of separation I think you'll need to make some additional changes:
|
|
@lcawl Which of the changes listed above need to be made before this PR is merged? The Beats docs use relative paths right now in the include statements (not attributes). We should probably improve that, but it hasn't caused build issues so far. |
lcawl
left a comment
There was a problem hiding this comment.
The syntax of this change is fine, though I've left two comments
|
@dedemorton If I remember correctly, the first errors you'll see will likely be related to files that have images in them. |
* Beats: add x-pack/filebeat/docs to contents This patch adds the x-pack/filebeat/docs to the list of directories to look for docs in Filebeat. This is needed so that we can include x-pack specific docs. * Set exclude_branches
This PR adds the
x-pack/filebeat/docsto the list of directories to look for docs in Filebeat. This is needed so that we can include x-pack specific docs.