Skip to content

add new path for kibana links check#2360

Merged
pgayvallet merged 2 commits intoelastic:masterfrom
pgayvallet:kbn-95389-server-side-docLinks
Jan 27, 2022
Merged

add new path for kibana links check#2360
pgayvallet merged 2 commits intoelastic:masterfrom
pgayvallet:kbn-95389-server-side-docLinks

Conversation

@pgayvallet
Copy link
Copy Markdown
Contributor

@pgayvallet pgayvallet commented Jan 27, 2022

Required for elastic/kibana#123818 / elastic/kibana#95389

Add the new package path for Kibana links checking

Copy link
Copy Markdown
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @pgayvallet

@gtback
Copy link
Copy Markdown
Member

gtback commented Jan 27, 2022

It would be great to see the Kibana PR fail without these changes (falling through to the failed to find kibana links file error), and then succeed once this is merged. But I'm just paranoid because Kibana link checking was incorrectly succeeding because of a stub file in the wrong place, for a long time (elastic/kibana#94274).

@gtback
Copy link
Copy Markdown
Member

gtback commented Jan 27, 2022

It would be great to see the Kibana PR fail without these changes

Nevermind, this won't happen because we still have a stub file in the old location that delegates to the new package.

@pgayvallet pgayvallet merged commit b3c1eb0 into elastic:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants