[Rule Tuning] Improve Compatibility in WIndows Detection Rules - Part 1#3501
Merged
[Rule Tuning] Improve Compatibility in WIndows Detection Rules - Part 1#3501
Conversation
Aegrah
approved these changes
Mar 11, 2024
| process.args : "Set-MpPreference" and process.args : ("-Disable*", "Disabled", "NeverSend", "-Exclusion*") | ||
| ( | ||
| process.name : ("powershell.exe", "pwsh.exe", "powershell_ise.exe") or | ||
| ?process.pe.original_file_name in ("powershell.exe", "pwsh.dll", "powershell_ise.exe") |
Contributor
There was a problem hiding this comment.
I barely ever see in used in Windows, due to case insensitivity. Of course, pe.original_file_name should always be the original file name, and if it's lowercase, in should be fine. Just pointing it out, that it might be a : candidate.
While continuing the review I noticed this in many rules, and I think it makes sense to use in and ==. So will leave it here as consideration, but LGTM!
Contributor
|
Great work 🚀 I reviewed all of the changes, taking into consideration your notes from the original comment. My only questions are:
These seem like rather small questions and should not be a blocker, therefore I am approving. |
terrancedejesus
approved these changes
Mar 12, 2024
Contributor
Author
The ones I've specified the sysmon index are non-process creation detections, which should only work with Sysmon data sources.
Yup, I tested a small subset of them, but not them all. It seemed enough to test if there were interferences in the results. |
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 13, 2024
… 1 (#3501) * Initial commit * Date bump Removed changes from: - rules/windows/credential_access_lsass_handle_via_malseclogon.toml - rules/windows/credential_access_potential_lsa_memdump_via_mirrordump.toml - rules/windows/credential_access_suspicious_lsass_access_generic.toml - rules/windows/credential_access_suspicious_lsass_access_memdump.toml - rules/windows/credential_access_suspicious_lsass_access_via_snapshot.toml - rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml - rules/windows/defense_evasion_suspicious_process_creation_calltrace.toml - rules/windows/initial_access_exfiltration_first_time_seen_usb.toml - rules/windows/persistence_sysmon_wmi_event_subscription.toml (selectively cherry picked from commit f5254f3)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 13, 2024
… 1 (#3501) * Initial commit * Date bump Removed changes from: - rules/windows/credential_access_lsass_handle_via_malseclogon.toml - rules/windows/credential_access_potential_lsa_memdump_via_mirrordump.toml - rules/windows/credential_access_suspicious_lsass_access_generic.toml - rules/windows/credential_access_suspicious_lsass_access_memdump.toml - rules/windows/credential_access_suspicious_lsass_access_via_snapshot.toml - rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml - rules/windows/defense_evasion_suspicious_process_creation_calltrace.toml - rules/windows/persistence_sysmon_wmi_event_subscription.toml (selectively cherry picked from commit f5254f3)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 13, 2024
… 1 (#3501) * Initial commit * Date bump Removed changes from: - rules/windows/credential_access_lsass_handle_via_malseclogon.toml - rules/windows/credential_access_potential_lsa_memdump_via_mirrordump.toml - rules/windows/credential_access_suspicious_lsass_access_generic.toml - rules/windows/credential_access_suspicious_lsass_access_memdump.toml - rules/windows/credential_access_suspicious_lsass_access_via_snapshot.toml - rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml - rules/windows/defense_evasion_suspicious_process_creation_calltrace.toml - rules/windows/persistence_sysmon_wmi_event_subscription.toml (selectively cherry picked from commit f5254f3)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 13, 2024
… 1 (#3501) * Initial commit * Date bump Removed changes from: - rules/windows/credential_access_lsass_handle_via_malseclogon.toml - rules/windows/credential_access_potential_lsa_memdump_via_mirrordump.toml - rules/windows/credential_access_suspicious_lsass_access_generic.toml - rules/windows/credential_access_suspicious_lsass_access_memdump.toml - rules/windows/credential_access_suspicious_lsass_access_via_snapshot.toml - rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml - rules/windows/defense_evasion_suspicious_process_creation_calltrace.toml - rules/windows/persistence_sysmon_wmi_event_subscription.toml (selectively cherry picked from commit f5254f3)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 13, 2024
… 1 (#3501) * Initial commit * Date bump Removed changes from: - rules/windows/credential_access_lsass_handle_via_malseclogon.toml - rules/windows/credential_access_potential_lsa_memdump_via_mirrordump.toml - rules/windows/credential_access_suspicious_lsass_access_generic.toml - rules/windows/credential_access_suspicious_lsass_access_memdump.toml - rules/windows/credential_access_suspicious_lsass_access_via_snapshot.toml - rules/windows/defense_evasion_suspicious_process_access_direct_syscall.toml - rules/windows/defense_evasion_suspicious_process_creation_calltrace.toml - rules/windows/persistence_sysmon_wmi_event_subscription.toml (selectively cherry picked from commit f5254f3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Resolves #3422
Summary
Implemented a lot of different changes in this PR, but some of them are:
logs-windows.powershell*Sysmon-Onlytag toData Source: Sysmonlogs-windows.sysmon_operational-*instead oflogs-windows.*This PR intentionally doesn't cover BBRs to include new data sources, as those rules need to be reviewed more closely to not cause performance problems.