Importing changes to os file set from ECS Beta 2#9763
Merged
webmat merged 2 commits intoelastic:masterfrom Jan 3, 2019
Merged
Conversation
os file set from ECS Beta 2os file set from ECS Beta 2
ruflin
approved these changes
Dec 27, 2018
Contributor
ruflin
left a comment
There was a problem hiding this comment.
LGTM
The part I still worry is that this bloats the template unnecessary as these fields are not used yet by any Beat.
added 2 commits
January 3, 2019 13:33
- Add `os.full` - Change `os.name` description - Change `os.version` example
bf52d42 to
d145000
Compare
andrewvc
approved these changes
Jan 3, 2019
Contributor
Author
|
@ruflin This is adding one field per index. Shouldn't be too bad :-) |
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
- Add field `os.full` - Tweak `os.name` description - Tweak `os.version` example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the Beta 2 update was done via #9645 and #9738. Only thing left is the last changes to the
osfield set.Since this is a reusable field set, the same modifications occur in multiple places. This is not Groundhog day, don't worry.
Changes:
os.namedefinitionos.fullfieldos.versionexample