Skip to content

Disable Central Management tests#9599

Merged
ph merged 1 commit intoelastic:masterfrom
ph:fix/disable-cm-tests
Dec 18, 2018
Merged

Disable Central Management tests#9599
ph merged 1 commit intoelastic:masterfrom
ph:fix/disable-cm-tests

Conversation

@ph
Copy link
Copy Markdown
Contributor

@ph ph commented Dec 17, 2018

Skipped because of: #9597

Need to be ported to 6.x

@ph ph added review needs_backport PR is waiting to be backported to other branches. :Testing labels Dec 17, 2018
@ph ph requested a review from a team as a code owner December 17, 2018 19:49
@ph ph requested review from jsoriano and webmat December 17, 2018 19:49
Copy link
Copy Markdown
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmat
Copy link
Copy Markdown
Contributor

webmat commented Dec 17, 2018

The Jenkins failure is unrelated.

That error is just a sign that an ingest node pipeline uses Painless and should pass in some params instead of hardcoding literals in the script. I'm not familiar with that test, though

@ph
Copy link
Copy Markdown
Contributor Author

ph commented Dec 17, 2018

@webmat This look like an upstream changes too I haven't seen that error before.

@ph
Copy link
Copy Markdown
Contributor Author

ph commented Dec 17, 2018

@webmat I think it's indeed unrelated to this changes, I've made a followup issues and ping infra on it. It is probably something that is changing in 7.0.

@webmat
Copy link
Copy Markdown
Contributor

webmat commented Dec 17, 2018

Here's an example where I faced that error, and used a param to pass in the literal value instead, and it fixed the problem. https://github.com/elastic/beats/pull/9308/files#diff-759f580883147ab049f76cd3501ec965R32

I don't currently understand why moving this literal inside the code triggers a compilation, however.

@ph ph merged commit ded3b76 into elastic:master Dec 18, 2018
@ph ph added v6.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 18, 2018
ph added a commit that referenced this pull request Dec 18, 2018
Cherry-pick of PR #9599 to 6.x branch. Original message: 

Skipped because of: #9597

Need to be ported to 6.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants