[Auditbeat] Change event.type to event.kind#9489
Merged
cwurm merged 3 commits intoelastic:feature-auditbeat-hostfrom Dec 12, 2018
Merged
[Auditbeat] Change event.type to event.kind#9489cwurm merged 3 commits intoelastic:feature-auditbeat-hostfrom
cwurm merged 3 commits intoelastic:feature-auditbeat-hostfrom
Conversation
Contributor
|
Pinging @elastic/secops |
tsg
approved these changes
Dec 11, 2018
webmat
approved these changes
Dec 11, 2018
Contributor
webmat
left a comment
There was a problem hiding this comment.
LGTM, once tests go green.
Only one test seemed to fail, potentially due to a Docker hiccup. So I restarted it (libbeat testsuite).
I'm not a big fan of TODOs in code, but in this case I'm good with them
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
Dec 16, 2018
To be compatible with ECS, changes the `event.type` field to `event.kind` throughout the system module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be compatible with ECS, this changes the
event.typefield toevent.kindthroughout the system module.Since
event.kindis not yet infields.ecs.yml, system tests are modified to skip failures related to that. There is a follow-up issue to add it.