Merged
Conversation
jsoriano
reviewed
Nov 22, 2018
Member
There was a problem hiding this comment.
Add a comment mentioning the reason why the test is skipped? or with a link to the issue?
9 tasks
62d7c89 to
6e0d544
Compare
6e0d544 to
26101de
Compare
Contributor
Author
|
@ph Can do, but will it make any difference? |
26101de to
95c8c72
Compare
Contributor
Author
|
@ph Changed. |
Contributor
it is just cleaner IMHO :) |
Contributor
|
@ruflin I have added needs_backport label, I think we want to disable that in all the current branches. |
ph
approved these changes
Nov 22, 2018
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Nov 22, 2018
See elastic#7690 (cherry picked from commit be187b9)
Contributor
Author
|
backported to 6.x. Would ignore it for now in 6.5. |
jsoriano
reviewed
Nov 23, 2018
| else: | ||
| assert data[0]["offset"] == 2 | ||
|
|
||
| @unittest.skip("Skipped as flaky: https://github.com/elastic/beats/issues/7690") |
jsoriano
reviewed
Nov 23, 2018
| """ | ||
| Checks that files which were removed, the state is removed | ||
| """ | ||
|
|
Contributor
Author
There was a problem hiding this comment.
nit ignored as already merged :-)
ph
pushed a commit
that referenced
this pull request
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #7690