Updating elasticsearch/ccr metricset with ES ccr_stats API changes#9179
Merged
ycombinator merged 3 commits intoelastic:masterfrom Nov 21, 2018
ycombinator:metricbeat-elasticsearch-ccr-update-schema
Merged
Updating elasticsearch/ccr metricset with ES ccr_stats API changes#9179ycombinator merged 3 commits intoelastic:masterfrom ycombinator:metricbeat-elasticsearch-ccr-update-schema
ycombinator merged 3 commits intoelastic:masterfrom
ycombinator:metricbeat-elasticsearch-ccr-update-schema
Conversation
chrisronline
approved these changes
Nov 20, 2018
Contributor
chrisronline
left a comment
There was a problem hiding this comment.
Functionality LGTM! I'm able to index monitoring documents that the UI expects!
Contributor
Author
|
jenkins, test this |
ruflin
approved these changes
Nov 21, 2018
Contributor
ruflin
left a comment
There was a problem hiding this comment.
LGTM from a code perspective. Didn't test it locally.
Sounds like this needs a changelog entry?
Contributor
There was a problem hiding this comment.
keep in mind for the backport ;-)
ycombinator
added a commit
that referenced
this pull request
Nov 26, 2018
…S ccr_stats API changes (#9201) * Updating elasticsearch/ccr metricset with ES ccr_stats API changes (#9179) Resolves elastic/kibana#25778. The ES CCR API changed a little before the 6.5.0 FF and we didn't catch these changes 😞. This PR updates the CCR metricset code to work with the new ES CCR API response structure. ## Testing this PR 1. Setup CCR: https://www.elastic.co/guide/en/elastic-stack-overview/current/ccr-getting-started.html 2. Checkout this PR and `make` Metricbeat: `cd metricbeat; make` 3. Enable the `elasticsearch` module: `./metricbeat modules enable elasticsearch` 4. Edit `modules.d/elasticsearch.yml` and make sure the `ccr` metricset is enabled and `xpack.enabled: true` is set. 5. Start Metricbeat: `./metricbeat -e` 6. After about 10-20 seconds, check that Metricbeat indexed the correct document of `type` = `ccr_stats` into `.monitoring-es-mb-6-*`. * Renaming field for 6.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves elastic/kibana#25778.
The ES CCR API changed a little before the 6.5.0 FF and we didn't catch these changes 😞. This PR updates the CCR metricset code to work with the new ES CCR API response structure.
Testing this PR
makeMetricbeat:cd metricbeat; makeelasticsearchmodule:./metricbeat modules enable elasticsearchmodules.d/elasticsearch.ymland make sure theccrmetricset is enabled andxpack.enabled: trueis set../metricbeat -etype=ccr_statsinto.monitoring-es-mb-6-*.