Conversation
docs/devguide/newdashboards.asciidoc
Outdated
There was a problem hiding this comment.
Will this PR be backported? If not, we could remove everything related to 5.x
There was a problem hiding this comment.
Yes, it is planned to as the label suggests.
b2f0a30 to
52b1fac
Compare
|
I added more E2E tests which cover requesting unknown dashboards and invalid files. |
ph
left a comment
There was a problem hiding this comment.
Added a note about my mistake in parsing URL :(
There was a problem hiding this comment.
I have a mistake, url.Parse or url.ParseRequestURL is well really bad see for yourself:
https://play.golang.org/p/9NAU0-sasfT
I think we have to come up with something better, maybe we already have in other outputs.
There was a problem hiding this comment.
In elasticsearch output url.Parse is used. Looking at the codebase, everytime we connect to something url.Parse is used. I think it is good enough.
|
If I remember correctly the |
|
@ruflin That's exactly how it worked. I added the option |
ph
left a comment
There was a problem hiding this comment.
👍 LGTM, I've looked at the CI this is a metricbeat/kafka docker issue.. nothing that this PR introduce.
6b096de to
ee19147
Compare
|
Added forgotten changelog entry. |
The existing `export_dashboards.go` and the command `export dashboards` are unified, using the same code and slightly different logic. Configuration of `export_dashboards` is done using the following command line options: `-kibana`, `-space`, `-output`, `-quiet` and `-index-pattern`. The last flag is an odd one out, because it is part of the script, but its value is never used. So far no one complained, so I did not port it. The default value of that flag is the same in case of both methods.
Configuration the Kibana client of `export dashboard` is read from the config of the Beat. Thus, Kibana-related flags are not part of its CLI.
By default `export dashboard` does not decode the exported dashboard. If flag `-decode` passed to the command, the dashboard is decoded.
export dashboards from a dashboards.yml
```
$ ./filebeat export dashboard -yml path/to/dashboards.yml -decode
$ go run dev-tools/cmd/dashboards/export_dashboards.go -yml path/to/dashboards.yml
```
export a dashboard with an id and print to stdout
```
$ ./filebeat export dashboard -id {uuid} -decode
$ go run dev-tools/cmd/dashboards/export_dashboards.go -dashboard {uuid}
```
(cherry picked from commit 1411852)
The existing `export_dashboards.go` and the command `export dashboards` are unified, using the same code and slightly different logic. Configuration of `export_dashboards` is done using the following command line options: `-kibana`, `-space`, `-output`, `-quiet` and `-index-pattern`. The last flag is an odd one out, because it is part of the script, but its value is never used. So far no one complained, so I did not port it. The default value of that flag is the same in case of both methods.
Configuration the Kibana client of `export dashboard` is read from the config of the Beat. Thus, Kibana-related flags are not part of its CLI.
By default `export dashboard` does not decode the exported dashboard. If flag `-decode` passed to the command, the dashboard is decoded.
export dashboards from a dashboards.yml
```
$ ./filebeat export dashboard -yml path/to/dashboards.yml -decode
$ go run dev-tools/cmd/dashboards/export_dashboards.go -yml path/to/dashboards.yml
```
export a dashboard with an id and print to stdout
```
$ ./filebeat export dashboard -id {uuid} -decode
$ go run dev-tools/cmd/dashboards/export_dashboards.go -dashboard {uuid}
```
(cherry picked from commit 1411852)
The existing
export_dashboards.goand the commandexport dashboardsare unified, using the same code and slightly different logic. Configuration ofexport_dashboardsis done using the following command line options:-kibana,-space,-output,-quietand-index-pattern. The last flag is an odd one out, because it is part of the script, but its value is never used. So far no one complained, so I did not port it. The default value of that flag is the same in case of both methods.Configuration the Kibana client of
export dashboardis read from the config of the Beat. Thus, Kibana-related flags are not part of its CLI.By default
export dashboarddoes not decode the exported dashboard. If flag-decodepassed to the command, the dashboard is decoded.Equivalent commands
export dashboards from a dashboards.yml
export a dashboard with an id and print to stdout
The interface of
export dashboardis different than in the previous PR, because I wanted to follow existing methods and documentation.TODO
export dashboardoption to dev docs