Skip to content

Temporary fix for dashboards under 7.0#9031

Merged
tsg merged 1 commit intoelastic:masterfrom
ruflin:dashboard-compatiblity
Nov 13, 2018
Merged

Temporary fix for dashboards under 7.0#9031
tsg merged 1 commit intoelastic:masterfrom
ruflin:dashboard-compatiblity

Conversation

@ruflin
Copy link
Copy Markdown
Contributor

@ruflin ruflin commented Nov 11, 2018

As some of libbeat fields were renamed in 7.0, currently a few dashboards break that depend on this fields. Adding an alias for the old fields is to temporarly fix this. As soon as the ECS migration is done, fields in the dashboard have to be renamed. Hopefully this can happen in an automated way.

@ruflin ruflin force-pushed the dashboard-compatiblity branch 2 times, most recently from 20050b7 to f1cf5cf Compare November 11, 2018 08:45
@ruflin
Copy link
Copy Markdown
Contributor Author

ruflin commented Nov 11, 2018

@tsg I tested this locally a bit and it seems to fix most dashboard issues. There is still something odd when I go to "System Host View" directly which I think is related to host.name in some way but when I go from the overview and click on the host it all works. I see this as an easy temporary fix for now

@ruflin ruflin requested a review from tsg November 11, 2018 08:54
@ruflin
Copy link
Copy Markdown
Contributor Author

ruflin commented Nov 11, 2018

This PR initially broke our tests. The reasons is that fields.ecs.yml is not taken into account when generating the fields.yml in libbeat which we use for the testing. It does not have an affect on the final fields.yml for each Beat as there the ecs fields are included. We should adjust our tests to not depend on the fields.yml in libbeat (later).

@webmat webmat added the ecs label Nov 12, 2018
tsg
tsg approved these changes Nov 12, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I approve of this.

@ruflin
Temporary fix for dashboards under 7.0
d060be2 
As some of libbeat fields were renamed in 7.0, currently a few dashboards break that depend on this fields. Adding an alias for the old fields is to temporarly fix this. As soon as the ECS migration is done, fields in the dashboard have to be renamed. Hopefully this can happen in an automated way.
@ruflin ruflin force-pushed the dashboard-compatiblity branch from 9f42b56 to d060be2 Compare November 13, 2018 03:19
@ruflin
Copy link
Copy Markdown
Contributor Author

ruflin commented Nov 13, 2018

@tsg I had to rebase again because of a conflict and want to make sure builds still go green. So if I don't get to merge it today, could you merge for me?

@tsg tsg merged commit 8afb012 into elastic:master Nov 13, 2018
@ruflin ruflin mentioned this pull request Nov 14, 2018
Closed
This was referenced Jan 22, 2019
Merged
Merged
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
@ruflin @tsg
Temporary fix for dashboards under 7.0 (elastic#9031)
34d868a 
As some of libbeat fields were renamed in 7.0, currently a few dashboards break that depend on this fields. Adding an alias for the old fields is to temporarly fix this. As soon as the ECS migration is done, fields in the dashboard have to be renamed. Hopefully this can happen in an automated way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tsg tsg tsg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ecs libbeat review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ruflin @tsg @webmat