rely on go to resolve beats repo for goimports install#8626
Merged
ruflin merged 1 commit intoelastic:masterfrom Oct 16, 2018
Merged
rely on go to resolve beats repo for goimports install#8626ruflin merged 1 commit intoelastic:masterfrom
ruflin merged 1 commit intoelastic:masterfrom
Conversation
jsoriano
approved these changes
Oct 16, 2018
Member
jsoriano
left a comment
There was a problem hiding this comment.
Thanks for this change, this is probably better 👍
ruflin
approved these changes
Oct 16, 2018
Contributor
|
@graphaelli Do you want to backport it? |
Member
Author
|
sure, will do |
Member
Author
|
Good news, this resolved the beats-update issue for apm-server |
graphaelli
added a commit
to graphaelli/beats
that referenced
this pull request
Oct 16, 2018
(cherry picked from commit db89540)
ruflin
pushed a commit
that referenced
this pull request
Oct 17, 2018
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Oct 17, 2018
(cherry picked from commit db89540)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Vendorize goimports (elastic#8619 and elastic#8626) Co-authored-by: Gil Raphaelli <g@raphaelli.com> (cherry picked from commits 6172a96 and e7f620f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as done for github.com/pierrre/gotestcover, github.com/stretchr/testify/assert, etc.
following up on #8619