Cherry-pick #7703 to 6.x: Adding more flexibility to describe a feature#8571
Merged
ph merged 1 commit intoelastic:6.xfrom Oct 5, 2018
ph:backport_7703_6.x
Merged
Cherry-pick #7703 to 6.x: Adding more flexibility to describe a feature#8571ph merged 1 commit intoelastic:6.xfrom ph:backport_7703_6.x
ph merged 1 commit intoelastic:6.xfrom
ph:backport_7703_6.x
Conversation
exekias
approved these changes
Oct 4, 2018
Contributor
|
I approved too fast 😇, It seems tests are failing |
Contributor
Author
|
hmm weird, I will fix that and ping you for it. |
* Adding more flexibility to describe a feature
Motivation:
Only adding a stability to describe a feature is often not enough,
instead we now allow to add the following information.
Fullname:
This is a more human readable version of the feature.
Example: Jolokia autodiscovery
Doc:
This is a one liner describing what you can do with the feature.
Example: The dissect processor allows to extract useful parts of the
original string.
Stability:
Describe how stable is the current feature.
* Remove the String() but keep the stringer interface implementation
* s/Describeable/Describer
* Add FilterWith that take a function predicate to filter the feature.
Currently we only provide the HasStabilityPred to filter feature from a
bundle, but this change open the door to chainable filterWith.
Example:
```
bundle.FilterWith(NamespaceMatchPred("processor"))
.FilterWith(HasStabilityPred(feature.Beta))
```
* Update overwrite signature.
(cherry picked from commit 91af9a7)
Contributor
Author
|
@exekias I've updated the PR I had a conflict but I have opted for the wrong resolution. |
Contributor
Author
|
I think #7476 should also be present, it was missing the need_backport label |
Contributor
Author
|
jenkins test this please |
exekias
approved these changes
Oct 5, 2018
Contributor
|
thank you for opening these @ph |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #7703 to 6.x branch. Original message:
Motivation:
Only adding a stability to describe a feature is often not enough,
instead we now allow to add the following information.
Fullname:
This is a more human readable version of the feature.
Example: Jolokia autodiscovery
Doc:
This is a one liner describing what you can do with the feature.
Example: The dissect processor allows to extract useful parts of the
original string.
Stability:
Describe how stable is the current feature.
From the conversation in #7443 (comment) to make the feature concept a bit more future proof.
Note: I've decided to use an interface in that case because it will be easier to give an upgrade path for feature developers.