Overwrite feature#7476
Merged
exekias merged 2 commits intoelastic:masterfrom Jul 25, 2018
ph:fix/overwrite-registry
Merged
Conversation
vjsamuel
reviewed
Jun 30, 2018
libbeat/feature/feature.go
Outdated
Contributor
There was a problem hiding this comment.
this is such a nice to have :)
exekias
reviewed
Jul 2, 2018
Contributor
exekias
left a comment
There was a problem hiding this comment.
Looking good!, left some comments
libbeat/feature/feature.go
Outdated
Contributor
There was a problem hiding this comment.
This function should not return anything, as it either works or panics
libbeat/feature/feature.go
Outdated
Allow to Overwrite an existing feature in the registry and add package level function to deal bundle that need to overwrite feature. This is require by the feature defined in the `add_kubernetes_metadata` processors, the core ships with a set of default options for the feature but a specific beats can decide to provide another set of default options.
Contributor
Author
|
@exekias ready for the final review. |
This was referenced Oct 4, 2018
ph
added a commit
that referenced
this pull request
Oct 5, 2018
Cherry-pick of PR #7476 to 6.x branch. Original message: Allow to Overwrite an existing feature in the registry and add package level function to deal bundle that need to overwrite feature. This is require by the feature defined in the `add_kubernetes_metadata` processors, the core ships with a set of default options for the feature but a specific beats can decide to provide another set of default options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to Overwrite an existing feature in the registry and add package
level function to deal bundle that need to overwrite feature.
This is require by the feature defined in the
add_kubernetes_metadataprocessors, the core ships with a set of default options for the feature
but a specific beats can decide to provide another set of default options.