Suppress dashboard info when dashboards aren't available#8395
Merged
dedemorton merged 1 commit intoelastic:masterfrom Sep 28, 2018
Merged
Suppress dashboard info when dashboards aren't available#8395dedemorton merged 1 commit intoelastic:masterfrom
dedemorton merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
We can automatically detect if a module has a dashboard or not and do it for the overview page. I wonder if we could do something similar here so it gets automatically updated and we don't have to apply it manually? |
Contributor
Author
|
@ruflin I knew we could do that for Metricbeat, but wasn't sure about Filebeat. We don't currently show dashboards on the Filebeat overview page. We'd need to set the |
Contributor
|
Correct, we don't do it for Filebeat at the moment (we probably could). As we don't have it yet, lets move forward with this manual solution and automated it later. |
ruflin
approved these changes
Sep 25, 2018
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Oct 17, 2018
dedemorton
added a commit
that referenced
this pull request
Oct 18, 2018
…8478) (#8529) * Clarify support for ssl options for modules (#7967) * Clarify support for ssl options for modules * Change example to show http module * Update Elasticsearch module examples to show http in the URL (#8226) * Improve reference docs that describe how to set options dynamically (#8290) * Improve Elasticsearch output docs about indices, pipelines, and keys settings * Updates from review * Change setting name from mapping to mappings * Remove note to reviewer * Fix conditional coding (#8446) * Suppress dashboard info when dashboards aren't available (#8395) * Clarify add_docker_metadata docs (#8478)
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Oct 18, 2018
dedemorton
added a commit
that referenced
this pull request
Oct 19, 2018
…8478) (#8528) * Clarify support for ssl options for modules (#7967) * Clarify support for ssl options for modules * Change example to show http module * Update Elasticsearch module examples to show http in the URL (#8226) * Improve reference docs that describe how to set options dynamically (#8290) * Improve Elasticsearch output docs about indices, pipelines, and keys settings * Updates from review * Change setting name from mapping to mappings * Remove note to reviewer * Fix conditional coding (#8446) * Suppress dashboard info when dashboards aren't available (#8395) * Clarify add_docker_metadata docs (#8478)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…tic#8290 elastic#8395 elastic#8446 elastic#8478) (elastic#8528) * Clarify support for ssl options for modules (elastic#7967) * Clarify support for ssl options for modules * Change example to show http module * Update Elasticsearch module examples to show http in the URL (elastic#8226) * Improve reference docs that describe how to set options dynamically (elastic#8290) * Improve Elasticsearch output docs about indices, pipelines, and keys settings * Updates from review * Change setting name from mapping to mappings * Remove note to reviewer * Fix conditional coding (elastic#8446) * Suppress dashboard info when dashboards aren't available (elastic#8395) * Clarify add_docker_metadata docs (elastic#8478)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8381
With these changes in place, dashboard-related content will be suppressed for Filebeat modules that do not include dashboards. I also did some cleanup work because attributes should be reset when their values are no longer needed.
Implementation note:
It would have been simpler to implement this as an
ifndefbut I was concerned that new module contributors would overlook the need to add the attribute. Having an attribute defined at the top of the file makes it more obvious that there's something to define, even if the module developer inadvertently removes the dashboard section without reading it first.