Skip to content

Adding elasticsearch/ccr metricset#8335

Merged
ycombinator merged 9 commits intoelastic:masterfrom
ycombinator:metricbeat-elasticsearch-ccr
Sep 19, 2018
Merged

Adding elasticsearch/ccr metricset#8335
ycombinator merged 9 commits intoelastic:masterfrom
ycombinator:metricbeat-elasticsearch-ccr

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented Sep 17, 2018 •
edited
Loading

This PR adds the elasticsearch/ccr metricset which collects cross-cluster replication (CCR) stats from the GET _ccr/stats Elasticsearch API and indexes them in metricbeat-*.

@ycombinator ycombinator added enhancement Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. v7.0.0-alpha1 v6.5.0 labels Sep 17, 2018
@ycombinator ycombinator mentioned this pull request Sep 17, 2018
Merged
@ruflin ruflin mentioned this pull request Sep 17, 2018
Closed
39 tasks
@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Sep 17, 2018

jenkins, test this

@chrisronline
Copy link
Copy Markdown
Contributor

chrisronline commented Sep 18, 2018

Do you have testing instructions available for this? I'm assuming you just need me to verify the collection has parity against the original?

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Sep 18, 2018

@chrisronline Yes, look for parity, same as before. I added concrete test instructions to the PR description.

@ycombinator ycombinator requested review from jsoriano and removed request for chrisronline September 18, 2018 17:20
sayden
sayden approved these changes Sep 19, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator ycombinator merged commit 0f2b29a into elastic:master Sep 19, 2018
@ycombinator ycombinator mentioned this pull request Sep 19, 2018
Merged
@ycombinator ycombinator added v6.5.0 and removed needs_backport PR is waiting to be backported to other branches. labels Sep 19, 2018
ycombinator added a commit that referenced this pull request Sep 24, 2018
@ycombinator
Cherry-pick #8335 to 6.x: Adding elasticsearch/ccr metricset (#8357)
4f14d66 
* Adding elasticsearch/ccr metricset (#8335)

This PR adds the `elasticsearch/ccr` metricset which collects cross-cluster replication (CCR) stats from the `GET _ccr/stats` Elasticsearch API and indexes them in `metricbeat-*`.

(cherry picked from commit 0f2b29a)

* Cleaning up CHANGELOG
@ycombinator ycombinator deleted the metricbeat-elasticsearch-ccr branch December 25, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

@ruflin ruflin Awaiting requested review from ruflin

+1 more reviewer

@sayden sayden sayden approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Metricbeat Metricbeat v6.5.0 v7.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ycombinator @chrisronline @jsoriano @sayden