Beatless initial PR#7837
Beatless initial PR#7837urso merged 8 commits intoelastic:feature/beatlessfrom ph:feature/beatless-main
Conversation
Add a new beat inside the x-pack folder under the Elastic License, minimal requirement changes to have a build and a test running.
| type Config struct { | ||
| } | ||
|
|
||
| var DefaultConfig = Config{} |
There was a problem hiding this comment.
exported var DefaultConfig should have comment or be unexported
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
we normally don't check in index patterns.
x-pack/beatless/data/meta.json
Outdated
| @@ -0,0 +1 @@ | |||
| {"uuid":"5c255ec6-8c55-418c-bc62-45bf3d411ed6"} | |||
There was a problem hiding this comment.
Data directory should be ignored.
x-pack/beatless/fields.yml
Outdated
| @@ -0,0 +1,220 @@ | |||
|
|
|||
There was a problem hiding this comment.
fields.yml should be ignored
|
Does |
|
Not yet I was waiting for @exekias PR to get merged.
On Thu, Aug 2, 2018 at 11:58 AM Steffen Siering ***@***.***> wrote:
Does make check check the license header is the correct one? E.g. only
AL2 license heaader outside of x-pack and not AL2 inside of x-pack
directory.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7837 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAACgEEMiHUgnomyIFqQOWXt5c1Alr6oks5uMyGigaJpZM4VrL0i>
.
--
ph
|
|
Could you provide an example |
x-pack/beatless/magefile.go
Outdated
| ) | ||
|
|
||
| func init() { | ||
| mage.SetBuildVariableSources(mage.DefaultBeatBuildVariableSources) |
There was a problem hiding this comment.
Is this line required? (Since it's in our repo hopefully it just works without setting this.)
x-pack/beatless/magefile.go
Outdated
| start := time.Now() | ||
| defer func() { fmt.Println("package ran for", time.Since(start)) }() | ||
|
|
||
| mage.UseCommunityBeatPackaging() |
There was a problem hiding this comment.
That's probably not right. I guess this needs something that does not exist that only loads the x-pack package specs.
@kvch There is no need to do that in that PR since there is no config validation, it's just the skeleton project to get going. |
|
@andrewkroh I've removed the line in question, but I am pretty green with the build magefile build system so it's certainly wrong.
|
|
@ph Sorry, I didn't express myself properly. Are we going to provide an example |
|
@kvch Oops sorry, Yes we will include one but since this PR doesn't have any config handling it's currently empty and is located at |
Main makefile exclude ASL2 for x-pack but check for Elastic. Beats can override the license in their Makefile.
|
This PR need the changes of #7783 to make sure we correctly compile the new beat. |
|
@andrewkroh @kvch @urso I think we can merge this as is, so I can rebase followup PRs on top of it. Concerning the development strategy I was looking into using a feature branch instead of merging directly to master until we have a working alpha. WDYT? |
* Beatless initial PR Add a new beat inside the x-pack folder under the Elastic License, minimal requirement changes to have a build and a test running. Main makefile exclude ASL2 for x-pack but check for Elastic. Beats can override the license in their Makefile.
* Beatless initial PR Add a new beat inside the x-pack folder under the Elastic License, minimal requirement changes to have a build and a test running. Main makefile exclude ASL2 for x-pack but check for Elastic. Beats can override the license in their Makefile.
* Beatless initial PR Add a new beat inside the x-pack folder under the Elastic License, minimal requirement changes to have a build and a test running. Main makefile exclude ASL2 for x-pack but check for Elastic. Beats can override the license in their Makefile.
* Beatless initial PR Add a new beat inside the x-pack folder under the Elastic License, minimal requirement changes to have a build and a test running. Main makefile exclude ASL2 for x-pack but check for Elastic. Beats can override the license in their Makefile.
* Beatless initial PR Add a new beat inside the x-pack folder under the Elastic License, minimal requirement changes to have a build and a test running. Main makefile exclude ASL2 for x-pack but check for Elastic. Beats can override the license in their Makefile.
* Beatless initial PR Add a new beat inside the x-pack folder under the Elastic License, minimal requirement changes to have a build and a test running. Main makefile exclude ASL2 for x-pack but check for Elastic. Beats can override the license in their Makefile.
* Beatless initial PR Add a new beat inside the x-pack folder under the Elastic License, minimal requirement changes to have a build and a test running. Main makefile exclude ASL2 for x-pack but check for Elastic. Beats can override the license in their Makefile.
* Beatless initial PR Add a new beat inside the x-pack folder under the Elastic License, minimal requirement changes to have a build and a test running. Main makefile exclude ASL2 for x-pack but check for Elastic. Beats can override the license in their Makefile.
Add a new beat inside the x-pack folder under the Elastic License, this is minimal requirement changes to have a build and a test running, no functionality is in.
make checkfails because ofmake fmtcomplaining about the license, to fix the issue with the check we need to get elastic/go-licenser#15 merged.Checkout the code and running
makeandmake testwill work.NOTES TO REVIEWERS:
feature/beatless