Skip to content

Elasticsearch index summary metricset#6918

Merged
exekias merged 1 commit intoelastic:masterfrom
ruflin:es-index-summary
May 9, 2018
Merged

Elasticsearch index summary metricset#6918
exekias merged 1 commit intoelastic:masterfrom
ruflin:es-index-summary

Conversation

@ruflin
Copy link
Copy Markdown
Contributor

@ruflin ruflin commented Apr 23, 2018

This provides stats for the summary across all Elasticsearch indicies. Starts are fetched from the _stats endpoint.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use an underscore in package name

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use an underscore in package name

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use an underscore in package name

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use an underscore in package name

@ruflin ruflin added the in progress Pull request is currently in progress. label Apr 23, 2018
@ruflin ruflin force-pushed the es-index-summary branch 3 times, most recently from 48615a5 to dbedd70 Compare April 30, 2018 13:23
@ruflin ruflin removed the in progress Pull request is currently in progress. label Apr 30, 2018
@ruflin ruflin force-pushed the es-index-summary branch 2 times, most recently from e4cd2c1 to 0213dc3 Compare May 3, 2018 14:03
@ruflin
Copy link
Copy Markdown
Contributor Author

ruflin commented May 4, 2018

jenkins, test this

@ruflin ruflin force-pushed the es-index-summary branch 3 times, most recently from f5fa8e4 to 3cdc538 Compare May 8, 2018 06:36
@ruflin ruflin force-pushed the es-index-summary branch 3 times, most recently from 65a88dd to 721c268 Compare May 9, 2018 12:26
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsoriano Does that look like discussed?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :)

Copy link
Copy Markdown
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left 2 nitpick comments

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this empty line?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty first line

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ;-) One day I will get used to it ...

This provides stats for the summary across all Elasticsearch indicies. Starts are fetched from the _stats endpoint.
@ruflin ruflin force-pushed the es-index-summary branch from 721c268 to d22c6d8 Compare May 9, 2018 19:27
@exekias exekias merged commit 9306c09 into elastic:master May 9, 2018
stevea78 pushed a commit to stevea78/beats that referenced this pull request May 20, 2018
This provides stats for the summary across all Elasticsearch indicies. Starts are fetched from the _stats endpoint.
stevea78 pushed a commit to stevea78/beats that referenced this pull request May 20, 2018
This provides stats for the summary across all Elasticsearch indicies. Starts are fetched from the _stats endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants