Skip to content

Remove settings from docs#4753

Merged
dedemorton merged 1 commit intoelastic:masterfrom
urso:docs/pipeline-remove-settings
Jul 27, 2017
Merged

Remove settings from docs#4753
dedemorton merged 1 commit intoelastic:masterfrom
urso:docs/pipeline-remove-settings

Conversation

@urso
Copy link
Copy Markdown

@urso urso commented Jul 25, 2017

  • remove removed settings in libbeat/filebeat docs
  • add tags/fields/fields_under_root/processor settings to every beat

@urso urso mentioned this pull request Jul 25, 2017
22 tasks
@urso urso changed the title Update docs Remove settings from docs Jul 25, 2017
@urso urso force-pushed the docs/pipeline-remove-settings branch from 02d9bed to 70b37f2 Compare July 26, 2017 12:37
@urso urso added in progress Pull request is currently in progress. and removed review labels Jul 26, 2017
@urso urso force-pushed the docs/pipeline-remove-settings branch from 70b37f2 to 4d87e36 Compare July 26, 2017 13:14
@urso urso added review and removed in progress Pull request is currently in progress. labels Jul 26, 2017
@urso urso force-pushed the docs/pipeline-remove-settings branch from 4d87e36 to 5ff1c34 Compare July 26, 2017 14:04
@tsg tsg added needs_backport PR is waiting to be backported to other branches. v6.0.0-GA labels Jul 26, 2017
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be level 4 (====), not 5.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be level 4 (====)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be level 4 (====)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be level 4 (====)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be level 4 (====)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be level 4 (====)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be level 4 (====)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be level 4 (====)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be level 4 (====)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be level 4 (====)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be level 4 (====)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be level 4 (====)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be level 4 (====)

Copy link
Copy Markdown
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments (one change to apply in multiple places).

Otherwise, LGTM

- remove removed settings in libbeat/filebeat docs
- add tags/fields/fields_under_root/processor settings to every beat
@urso urso force-pushed the docs/pipeline-remove-settings branch from 5ff1c34 to 8435e3f Compare July 27, 2017 18:58
@dedemorton dedemorton merged commit 4b7f097 into elastic:master Jul 27, 2017
urso pushed a commit to urso/beats that referenced this pull request Aug 11, 2017
- remove removed settings in libbeat/filebeat docs
- add tags/fields/fields_under_root/processor settings to every beat
(cherry picked from commit 4b7f097)
@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Aug 11, 2017
andrewkroh pushed a commit that referenced this pull request Aug 16, 2017
- remove removed settings in libbeat/filebeat docs
- add tags/fields/fields_under_root/processor settings to every beat

(cherry picked from commit 4b7f097)
@urso urso deleted the docs/pipeline-remove-settings branch February 19, 2019 18:38
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
- remove removed settings in libbeat/filebeat docs
- add tags/fields/fields_under_root/processor settings to every beat

(cherry picked from commit 2c07801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants