Fix TCP & UDP input metricsets for ports > 32767 by belimawr · Pull Request #46486 · elastic/beats

belimawr · 2025-09-09T21:48:37Z

Proposed commit message

When parsing the port to collect metrics, the TCP & UDP inputs were
parsing the port as a int16, which limited the maximum port to
32767. This commit fixes it by parsing the port as uint16.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

~~## Disruptive User Impact~~
~~## Author's Checklist~~

How to test this PR locally

Start Filebeat with the following configuration:

filebeat.inputs:
  - type: udp
    host: 127.0.0.1:42000

output.discard:
  enabled: true

logging:
  to_stderr: true
  level: warning

http.enabled: true

Ensure the following waring is not in the logs:

{
  "log.level": "warn",
  "@timestamp": "2025-09-09T18:02:06.893-0400",
  "log.logger": "input.udp",
  "log.origin": {
    "function": "github.com/elastic/beats/v7/filebeat/input/netmetrics.NewUDP",
    "file.name": "netmetrics/udp.go",
    "file.line": 65
  },
  "message": "failed to get port for 127.0.0.1:42000: strconv.ParseInt: parsing \"42000\": value out of range",
  "service.name": "filebeat",
  "id": "8C542040A200BF6D",
  "host": "127.0.0.1:42000",
  "ecs.version": "1.6.0"
}

Start sending some data in the UDP port

docker run -it --rm mingrammer/flog -l | nc -vu localhost 42000

Get the input metrics from http://localhost:5066/inputs/ and ensure receive_queue_length is populated.
```
curl http://localhost:5066/inputs/ -s|jq '.[].receive_queue_length'
```
You might have to call curl multiple times, as the value some times is zero.

~~## Related issues~~
~~## Use cases~~
~~## Screenshots~~
~~## Logs~~

When parsing the port to collect metrics, the TCP & UDP inputs were parsing the port as a int16, which limited the maximum port to 32767. This commit fixes it by parsing the port as uint16.

github-actions · 2025-09-09T21:48:47Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

mergify · 2025-09-09T21:49:15Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @belimawr? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

elasticmachine · 2025-09-10T15:58:09Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

github-actions · 2025-09-10T18:43:52Z

@Mergifyio backport 8.18 8.19 9.0 9.1

mergify · 2025-09-10T18:44:21Z

backport 8.18 8.19 9.0 9.1

✅ Backports have been created

Details

#46522 [8.18](backport #46486) Fix TCP & UDP input metricsets for ports > 32767 has been created for branch 8.18 but encountered conflicts
#46523 [8.19](backport #46486) Fix TCP & UDP input metricsets for ports > 32767 has been created for branch 8.19
#46524 [9.0](backport #46486) Fix TCP & UDP input metricsets for ports > 32767 has been created for branch 9.0 but encountered conflicts
#46525 [9.1](backport #46486) Fix TCP & UDP input metricsets for ports > 32767 has been created for branch 9.1

When parsing the port to collect metrics, the TCP & UDP inputs were parsing the port as a int16, which limited the maximum port to 32767. This commit fixes it by parsing the port as uint16. (cherry picked from commit 8ee7685) # Conflicts: # filebeat/input/netmetrics/netmetrics_test.go

When parsing the port to collect metrics, the TCP & UDP inputs were parsing the port as a int16, which limited the maximum port to 32767. This commit fixes it by parsing the port as uint16. (cherry picked from commit 8ee7685)

When parsing the port to collect metrics, the TCP & UDP inputs were parsing the port as a int16, which limited the maximum port to 32767. This commit fixes it by parsing the port as uint16. (cherry picked from commit 8ee7685) # Conflicts: # filebeat/input/netmetrics/netmetrics_test.go

When parsing the port to collect metrics, the TCP & UDP inputs were parsing the port as a int16, which limited the maximum port to 32767. This commit fixes it by parsing the port as uint16. (cherry picked from commit 8ee7685)

When parsing the port to collect metrics, the TCP & UDP inputs were parsing the port as a int16, which limited the maximum port to 32767. This commit fixes it by parsing the port as uint16.

…67 (#46524) * Fix TCP & UDP input metricsets for ports > 32767 (#46486) When parsing the port to collect metrics, the TCP & UDP inputs were parsing the port as a int16, which limited the maximum port to 32767. This commit fixes it by parsing the port as uint16. (cherry picked from commit 8ee7685) # Conflicts: # filebeat/input/netmetrics/netmetrics_test.go * Fix merge conflicts --------- Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>

When parsing the port to collect metrics, the TCP & UDP inputs were parsing the port as a int16, which limited the maximum port to 32767. This commit fixes it by parsing the port as uint16. (cherry picked from commit 8ee7685) Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>

…767 (#46523) * Fix TCP & UDP input metricsets for ports > 32767 (#46486) When parsing the port to collect metrics, the TCP & UDP inputs were parsing the port as a int16, which limited the maximum port to 32767. This commit fixes it by parsing the port as uint16. (cherry picked from commit 8ee7685) * Fix merge conflicts --------- Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>

…767 (#46522) * Fix TCP & UDP input metricsets for ports > 32767 (#46486) When parsing the port to collect metrics, the TCP & UDP inputs were parsing the port as a int16, which limited the maximum port to 32767. This commit fixes it by parsing the port as uint16. (cherry picked from commit 8ee7685) # Conflicts: # filebeat/input/netmetrics/netmetrics_test.go * Fix merge conflicts --------- Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>

Fix TCP & UDP input metricsets for ports > 32767

a934b10

When parsing the port to collect metrics, the TCP & UDP inputs were parsing the port as a int16, which limited the maximum port to 32767. This commit fixes it by parsing the port as uint16.

belimawr self-assigned this Sep 9, 2025

belimawr added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 9, 2025

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 9, 2025

Changelog

04c1b5a

belimawr marked this pull request as ready for review September 10, 2025 15:58

belimawr requested a review from a team as a code owner September 10, 2025 15:58

belimawr requested review from AndersonQ and rdner September 10, 2025 15:58

belimawr added the backport-active-all Automated backport with mergify to all the active branches label Sep 10, 2025

cmacknz approved these changes Sep 10, 2025

View reviewed changes

belimawr merged commit 8ee7685 into elastic:main Sep 10, 2025
50 of 53 checks passed

mergify bot mentioned this pull request Sep 10, 2025

[8.18](backport #46486) Fix TCP & UDP input metricsets for ports > 32767 #46522

Merged

6 tasks

mergify bot mentioned this pull request Sep 10, 2025

[8.19](backport #46486) Fix TCP & UDP input metricsets for ports > 32767 #46523

Merged

6 tasks

mergify bot mentioned this pull request Sep 10, 2025

[9.0](backport #46486) Fix TCP & UDP input metricsets for ports > 32767 #46524

Merged

6 tasks

mergify bot mentioned this pull request Sep 10, 2025

[9.1](backport #46486) Fix TCP & UDP input metricsets for ports > 32767 #46525

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix TCP & UDP input metricsets for ports > 32767#46486

Fix TCP & UDP input metricsets for ports > 32767#46486
belimawr merged 2 commits intoelastic:mainfrom
belimawr:fix-tcp-udp-ports

belimawr commented Sep 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

mergify bot commented Sep 9, 2025

Uh oh!

elasticmachine commented Sep 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 10, 2025

Uh oh!

mergify bot commented Sep 10, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

belimawr commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed commit message

Checklist

How to test this PR locally

Uh oh!

github-actions bot commented Sep 9, 2025

🤖 GitHub comments

Uh oh!

mergify bot commented Sep 9, 2025

Uh oh!

elasticmachine commented Sep 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 10, 2025

Uh oh!

mergify bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

belimawr commented Sep 9, 2025 •

edited

Loading

mergify bot commented Sep 10, 2025 •

edited

Loading