Filebeat modules: Machine learning jobs#4506
Conversation
|
I pushed everything, but I expect the test to be failing until the Kibana snapshots are fixed (there's an issue with the current ones). But should be otherwise ready for reviews. |
|
Also, I'm leaving docs for later, since this will mainly mean document the |
exekias
left a comment
There was a problem hiding this comment.
LGTM in general, but some tests are failing, looks legit, you may want to take a look to them
filebeat/beater/filebeat.go
Outdated
0b9286e to
3c04b7f
Compare
This adds support for loading ML configurations (job + datafeed) from the filebeat modules. An example ML configuration is added to the Nginx Filebeat module. This sample applies ML anomaly detection on the response codes. The loading is implemented as part of the `setup` command and part of the `--setup` flag. If a job configuration with the same ID exists, it is not overwritten, because deleting jobs could potentially delete user data. The user should manually delete the jobs in the UI if they want to upgrade.
3c04b7f to
68641f6
Compare
|
Squashed and rebased. Remaining test failures seem unrelated, but I'm hoping for some more green on this run. |
|
💯 tested by hand, it adds the job both with |
| @@ -0,0 +1,44 @@ | |||
| { | |||
| "job_id": "JOB_ID", | |||
There was a problem hiding this comment.
Only skimmed through the PR but this kind of looked fishy?
There was a problem hiding this comment.
Yeah, it gets replaced in code with a generated job id. Didn't know how to reflect this otherwise.
There was a problem hiding this comment.
To clarify, I don't mean a textual replacement. The json gets decoded and the key replaced.
This adds support for loading ML configurations (job + datafeed) from the filebeat modules. An example ML configuration is added to the Nginx Filebeat module. This sample applies ML anomaly detection on the response codes. The loading is implemented as part of the `setup` command and part of the `--setup` flag. If a job configuration with the same ID exists, it is not overwritten, because deleting jobs could potentially delete user data. The user should manually delete the jobs in the UI if they want to upgrade. (cherry picked from commit 1213483)
) * Filebeat modules: Machine Learning jobs (#4506) This adds support for loading ML configurations (job + datafeed) from the filebeat modules. An example ML configuration is added to the Nginx Filebeat module. This sample applies ML anomaly detection on the response codes. The loading is implemented as part of the `setup` command and part of the `--setup` flag. If a job configuration with the same ID exists, it is not overwritten, because deleting jobs could potentially delete user data. The user should manually delete the jobs in the UI if they want to upgrade. (cherry picked from commit 1213483) * use 5.5 snapshots for now * Adjusted test for 5.x * Another test adjustments * On a 400 response on _xpack, assume that Xpack is not installed * Another test fix
This adds support for loading ML configurations (job + datafeed) from the filebeat modules. An example ML configuration is added to the Nginx Filebeat module. This sample applies ML anomaly detection on the response codes.
The loading is implemented as part of the
setupcommand and part of the--setupflag.If a job configuration with the same ID exists, it is not overwritten, because deleting jobs could potentially delete user data. The user should manually delete the jobs in the UI if they want to upgrade.
ToDOs for the overall implementation:
snaphost.yml)