[Chore][libbeat] Replace global logger with single logger instance #2#43493
Merged
pierrehilbert merged 85 commits intoelastic:mainfrom Apr 2, 2025
Merged
[Chore][libbeat] Replace global logger with single logger instance #2#43493pierrehilbert merged 85 commits intoelastic:mainfrom
pierrehilbert merged 85 commits intoelastic:mainfrom
Conversation
Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
rdner
reviewed
Mar 31, 2025
leehinman
requested changes
Mar 31, 2025
Contributor
leehinman
left a comment
There was a problem hiding this comment.
Looking good, thank you for doing this.
My only requested change is lets not change the formatting of the error messages in this PR.
khushijain21
commented
Apr 1, 2025
khushijain21
commented
Apr 1, 2025
khushijain21
commented
Apr 1, 2025
khushijain21
commented
Apr 1, 2025
rdner
approved these changes
Apr 2, 2025
Member
rdner
left a comment
There was a problem hiding this comment.
Overall looks good to me, I found a suspicious line where I left my comment.
leehinman
reviewed
Apr 2, 2025
leehinman
approved these changes
Apr 2, 2025
VihasMakwana
approved these changes
Apr 2, 2025
pierrehilbert
approved these changes
Apr 2, 2025
Contributor
|
@nfritts could we have someone to review here please? |
nfritts
approved these changes
Apr 2, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
…43493) * [Chore] Use single logger instance * Update x-pack/filebeat/fbreceiver/receiver_test.go Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> * Update x-pack/filebeat/fbreceiver/receiver_test.go Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> * libbeat/cmd is complete * keep only libbeat changes * keep only libbeat changes * add libbeat/monitoring/report package * add my fork * use beat.Info.Logger * remove cloudid * remove println * fix tests * add libbeat/idxmgmt * add libbeat/monitoring/report * go mod tidy * fix idxmgmt tests * fixing and finishing things * fix tests * fix tests * fix tests * debugging statement * stringify debug statement * fixing tests * fixing tests * add libbeat/instrumentation * update ea-libs * fix lint * fix tests and lint * golangci lint * initialize logger before using in instrumentation * address review comments * address review comments 2 * add libbeat/output & libbeat/template * fix tests * add libbeat/dashboards & libbeat/cfgfile * add libbeat/dashboards & libbeat/cfgfile * fix lint * add libbeat/persistentcache * mage check * mage check * merge and fix tests * fix test * add logger on metricbeat * fix lint * fix lint * fix tests * address review comments * lint check * fix lint * fix lint * fix lint * fix lint * fix lint * fix lint in redis files * lint fix * fix lint * fix lint and tests * fix logstash test * fix test reload functionality * add integration build tag * use t.TempDir and non-capitalize logged errors * add linter check * fix log discrepancy * add nolint for errors starting with capitalized letter * fix logger discrepancy * add linting fixes --------- Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> (cherry picked from commit 8920a05) # Conflicts: # filebeat/beater/filebeat.go # heartbeat/beater/heartbeat.go # libbeat/autodiscover/autodiscover_test.go # libbeat/cfgfile/reload.go # libbeat/cmd/instance/beat.go # libbeat/outputs/elasticsearch/client_integration_test.go # libbeat/outputs/elasticsearch/client_test.go # libbeat/outputs/logstash/logstash_integration_test.go # metricbeat/beater/metricbeat.go
khushijain21
added a commit
that referenced
this pull request
Jun 6, 2025
…43493) * [Chore] Use single logger instance * Update x-pack/filebeat/fbreceiver/receiver_test.go Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> * Update x-pack/filebeat/fbreceiver/receiver_test.go Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> * libbeat/cmd is complete * keep only libbeat changes * keep only libbeat changes * add libbeat/monitoring/report package * add my fork * use beat.Info.Logger * remove cloudid * remove println * fix tests * add libbeat/idxmgmt * add libbeat/monitoring/report * go mod tidy * fix idxmgmt tests * fixing and finishing things * fix tests * fix tests * fix tests * debugging statement * stringify debug statement * fixing tests * fixing tests * add libbeat/instrumentation * update ea-libs * fix lint * fix tests and lint * golangci lint * initialize logger before using in instrumentation * address review comments * address review comments 2 * add libbeat/output & libbeat/template * fix tests * add libbeat/dashboards & libbeat/cfgfile * add libbeat/dashboards & libbeat/cfgfile * fix lint * add libbeat/persistentcache * mage check * mage check * merge and fix tests * fix test * add logger on metricbeat * fix lint * fix lint * fix tests * address review comments * lint check * fix lint * fix lint * fix lint * fix lint * fix lint * fix lint in redis files * lint fix * fix lint * fix lint and tests * fix logstash test * fix test reload functionality * add integration build tag * use t.TempDir and non-capitalize logged errors * add linter check * fix log discrepancy * add nolint for errors starting with capitalized letter * fix logger discrepancy * add linting fixes --------- Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See https://github.com/elastic/ingest-dev/issues/5251
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run this test in
x-pack/filebeat/fbreceivergo test -run ^TestMultipleReceivers$ ./x-pack/filebeat/fbreceiver -vRelated issues