Skip to content

Correct the default filename of events-data#41808

Merged
rdner merged 3 commits intoelastic:8.16from
f1tz:patch-1
Dec 12, 2024
Merged

Correct the default filename of events-data#41808
rdner merged 3 commits intoelastic:8.16from
f1tz:patch-1

Conversation

@f1tz
Copy link
Copy Markdown
Contributor

@f1tz f1tz commented Nov 27, 2024

Change 'event-data' to 'events-data' in the document.

Reference:

beats/libbeat/tests/system/beat/beat.py

Line 535 in 1bd39c5

logfile = self.beat_name + "-events-data-" + self.today + ".ndjson"

beats/libbeat/tests/integration/framework.go

Line 626 in 1bd39c5

glob := fmt.Sprintf("%s-events-data-%d*.ndjson", filepath.Join(b.tempDir, b.beatName), year)

@f1tz f1tz requested a review from a team as a code owner November 27, 2024 10:20
@f1tz f1tz requested review from AndersonQ and rdner and removed request for a team November 27, 2024 10:20
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 27, 2024
@cla-checker-service
Copy link
Copy Markdown

cla-checker-service bot commented Nov 27, 2024 •
edited
Loading

💚 CLA has been signed

@mergify mergify bot assigned f1tz Nov 27, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 27, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 27, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 27, 2024
@pierrehilbert
Copy link
Copy Markdown
Contributor

pierrehilbert commented Nov 27, 2024

Thanks @f1tz for your contribution.
Could you please sign our CLA?

@f1tz
Copy link
Copy Markdown
Contributor Author

f1tz commented Nov 27, 2024

Thanks @f1tz for your contribution. Could you please sign our CLA?

Thanks, I have already signed the CLA.

@rdner
Copy link
Copy Markdown
Member

rdner commented Dec 3, 2024

@f1tz thank you for your contribution!
Would you mind to fix the rest of the occurrences in this PR?

https://github.com/search?q=repo%3Aelastic%2Fbeats+-event-data&type=code

It would be nice to do that in one go, so all the docs are in sync. Thanks!

@belimawr as you worked on #38767, I think it might be a typo in the filename actually, not in the docs because all the config parameters have event_data in them.

What do you think we should fix here?

@belimawr
Copy link
Copy Markdown
Contributor

belimawr commented Dec 3, 2024

@belimawr as you worked on #38767, I think it might be a typo in the filename actually, not in the docs because all the config parameters have event_data in them.

What do you think we should fix here?

Yes, indeed it's a typo in the docs. I believe the only other file that needs updating is libbeat/_meta/config/logging.reference.yml.tmpl, the other configuration files are generated from it.

@belimawr belimawr self-requested a review December 3, 2024 22:24
@nimarezainia
Copy link
Copy Markdown
Contributor

nimarezainia commented Dec 3, 2024

@belimawr as you worked on #38767, I think it might be a typo in the filename actually, not in the docs because all the config parameters have event_data in them.
What do you think we should fix here?

Yes, indeed it's a typo in the docs. I believe the only other file that needs updating is libbeat/_meta/config/logging.reference.yml.tmpl, the other configuration files are generated from it.

@belimawr could you please open an issue with this detail so it can get addressed (fyi @kilfoyle )

@belimawr belimawr mentioned this pull request Dec 3, 2024
Merged
@belimawr
Copy link
Copy Markdown
Contributor

belimawr commented Dec 3, 2024

@belimawr could you please open an issue with this detail so it can get addressed (fyi @kilfoyle )

@nimarezainia I believe this feature only documented here and in the Elastic-Agent standalone logging, so I just created the PR to fix it: elastic/ingest-docs#1520

@nimarezainia
Copy link
Copy Markdown
Contributor

nimarezainia commented Dec 4, 2024

@belimawr could you please open an issue with this detail so it can get addressed (fyi @kilfoyle )

@nimarezainia I believe this feature only documented here and in the Elastic-Agent standalone logging, so I just created the PR to fix it: elastic/ingest-docs#1520

thank you much appreciated,

This was referenced Dec 4, 2024
Merged
Merged
Merged
Merged
@rdner
Copy link
Copy Markdown
Member

rdner commented Dec 10, 2024

@f1tz could you please update

beats/libbeat/_meta/config/logging.reference.yml.tmpl

Line 95 in 5a85598

#name: {{.BeatName}}-event-data
and then run make update in the root of the repository.

This should update all the occurrences of this typo. Thanks!

@rdner rdner requested review from a team as code owners December 10, 2024 16:37
@rdner rdner requested a review from a team as a code owner December 10, 2024 16:37
@rdner
Copy link
Copy Markdown
Member

rdner commented Dec 11, 2024

/test

@rdner rdner merged commit 9b66bb0 into elastic:8.16 Dec 12, 2024
@rdner rdner added backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Dec 12, 2024
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
@f1tz @rdner @mergify
Correct the default filename of events-data (#41808)
5cf5299 
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
(cherry picked from commit 9b66bb0)
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
@f1tz @rdner @mergify
Correct the default filename of events-data (#41808)
a584311 
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
(cherry picked from commit 9b66bb0)
This was referenced Dec 12, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
@f1tz @rdner @mergify
Correct the default filename of events-data (#41808)
a4e7a38 
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
(cherry picked from commit 9b66bb0)
@mergify mergify bot mentioned this pull request Dec 12, 2024
Merged
rdner pushed a commit that referenced this pull request Dec 13, 2024
@mergify @f1tz
Correct the default filename of events-data (#41808) (#42021)
05c9b66 
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
(cherry picked from commit 9b66bb0)

Co-authored-by: Agent Fitz ;-) <fitz.bao@outlook.com>
rdner pushed a commit that referenced this pull request Dec 13, 2024
@mergify @f1tz
Correct the default filename of events-data (#41808) (#42023)
89a4b9c 
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
(cherry picked from commit 9b66bb0)

Co-authored-by: Agent Fitz ;-) <fitz.bao@outlook.com>
@rdner rdner added the forwardport-main Automated forwardport with mergify label Dec 13, 2024
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@f1tz @mergify
Correct the default filename of events-data (#41808)
364ab63 
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
(cherry picked from commit 9b66bb0)

# Conflicts:
#	x-pack/functionbeat/functionbeat.reference.yml
@mergify mergify bot mentioned this pull request Dec 13, 2024
Merged
rdner added a commit that referenced this pull request Dec 13, 2024
@mergify @f1tz @rdner
Correct the default filename of events-data (#41808) (#42022)
ce5ddb0 
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
(cherry picked from commit 9b66bb0)

Co-authored-by: Agent Fitz ;-) <fitz.bao@outlook.com>
Co-authored-by: Denis <denis.rechkunov@elastic.co>
rdner added a commit that referenced this pull request Jan 10, 2025
@mergify @f1tz @rdner
[main](backport #41808) Correct the default filename of events-data (#…
653fc80 
…42035)

* Correct the default filename of events-data (#41808)

* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
(cherry picked from commit 9b66bb0)

# Conflicts:
#	x-pack/functionbeat/functionbeat.reference.yml

* Delete x-pack/functionbeat/functionbeat.reference.yml

---------

Co-authored-by: Agent Fitz ;-) <fitz.bao@outlook.com>
Co-authored-by: Denis <denis.rechkunov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gizas gizas gizas approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-data-plane

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@belimawr belimawr Awaiting requested review from belimawr

Assignees

@f1tz f1tz

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify forwardport-main Automated forwardport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@f1tz @elasticmachine @pierrehilbert @rdner @belimawr @nimarezainia @gizas