Skip to content

x-pack/filebeat/input/awss3: support for Access Point ARN#41495

Merged
chemamartinez merged 11 commits intoelastic:mainfrom
chemamartinez:41494-awss3-access_point
Nov 19, 2024
Merged

x-pack/filebeat/input/awss3: support for Access Point ARN#41495
chemamartinez merged 11 commits intoelastic:mainfrom
chemamartinez:41494-awss3-access_point

Conversation

@chemamartinez
Copy link
Copy Markdown
Contributor

@chemamartinez chemamartinez commented Oct 31, 2024 •
edited
Loading

Proposed commit message

Added a new option access_point_arn to the AWS S3 input as an alternative to the bucket ARN to access S3 buckets.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@chemamartinez chemamartinez added enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team labels Oct 31, 2024
@chemamartinez chemamartinez self-assigned this Oct 31, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 31, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 31, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @chemamartinez? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 31, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 31, 2024
@chemamartinez chemamartinez mentioned this pull request Oct 31, 2024
Closed
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 6, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 41494-awss3-access_point upstream/41494-awss3-access_point
git merge upstream/main
git push upstream 41494-awss3-access_point

@chemamartinez chemamartinez force-pushed the 41494-awss3-access_point branch from d3b8e50 to 827c92e Compare November 13, 2024 17:40
@chemamartinez chemamartinez force-pushed the 41494-awss3-access_point branch from 827c92e to 148d6c6 Compare November 13, 2024 17:41
@chemamartinez chemamartinez added backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify labels Nov 13, 2024
@chemamartinez chemamartinez force-pushed the 41494-awss3-access_point branch from c501329 to dfb0fdb Compare November 13, 2024 18:09
@chemamartinez chemamartinez marked this pull request as ready for review November 14, 2024 09:00
@chemamartinez chemamartinez requested review from a team as code owners November 14, 2024 09:00
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 14, 2024

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@chemamartinez chemamartinez mentioned this pull request Nov 14, 2024
Closed
19 tasks
ShourieG
ShourieG reviewed Nov 18, 2024
View reviewed changes
ShourieG
ShourieG reviewed Nov 18, 2024
View reviewed changes
ShourieG
ShourieG approved these changes Nov 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndersonQ
Copy link
Copy Markdown
Member

AndersonQ commented Nov 18, 2024

LGTM, just make sure to do not merge the 8.16 backport until 8.16.1 is released.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 18, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 41494-awss3-access_point upstream/41494-awss3-access_point
git merge upstream/main
git push upstream 41494-awss3-access_point

kaiyan-sheng
kaiyan-sheng reviewed Nov 18, 2024
View reviewed changes
kaiyan-sheng
kaiyan-sheng reviewed Nov 18, 2024
View reviewed changes
@kaiyan-sheng
Copy link
Copy Markdown
Contributor

kaiyan-sheng commented Nov 18, 2024

Looks good to me. Can we create an issue in the integrations repo to add this new parameter later in related data streams please? Thanks!

strawgate
strawgate reviewed Nov 18, 2024
View reviewed changes
@strawgate
Copy link
Copy Markdown
Contributor

strawgate commented Nov 18, 2024

Does setting the Access Point ARN work when using SQS?

@chemamartinez
Copy link
Copy Markdown
Contributor Author

chemamartinez commented Nov 18, 2024

Looks good to me. Can we create an issue in the integrations repo to add this new parameter later in related data streams please? Thanks!

Thank you for the review. The issue for updating the integrations is elastic/integrations#11737.

@chemamartinez chemamartinez removed the backport-8.15 Automated backport to the 8.15 branch with mergify label Nov 19, 2024
@chemamartinez chemamartinez merged commit 301988d into elastic:main Nov 19, 2024
mergify bot pushed a commit that referenced this pull request Nov 19, 2024
@chemamartinez @mergify
x-pack/filebeat/input/awss3: support for Access Point ARN (#41495)
f461d90 
Added a new option access_point_arn to the AWS S3 input as an alternative to the bucket ARN to access S3 buckets.

(cherry picked from commit 301988d)
@mergify mergify bot mentioned this pull request Nov 19, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Nov 19, 2024
@chemamartinez @mergify
x-pack/filebeat/input/awss3: support for Access Point ARN (#41495)
159e899 
Added a new option access_point_arn to the AWS S3 input as an alternative to the bucket ARN to access S3 buckets.

(cherry picked from commit 301988d)
@mergify mergify bot mentioned this pull request Nov 19, 2024
Merged
6 tasks
chemamartinez pushed a commit that referenced this pull request Nov 19, 2024
@mergify
[8.x](backport #41495) x-pack/filebeat/input/awss3: support for Acces…
76a381c 
…s Point ARN (#41689)

Added a new option access_point_arn to the AWS S3 input as an alternative to the bucket ARN to access S3 buckets.
chemamartinez pushed a commit that referenced this pull request Nov 22, 2024
@mergify
[8.16](backport #41495) x-pack/filebeat/input/awss3: support for Acce…
dcad799 
…ss Point ARN (#41688)

* x-pack/filebeat/input/awss3: support for Access Point ARN (#41495)

Backport: Added a new option access_point_arn to the AWS S3 input as an alternative to the bucket ARN to access S3 buckets.
@chemamartinez chemamartinez mentioned this pull request Dec 18, 2024
Merged
5 tasks
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndersonQ AndersonQ AndersonQ approved these changes

@belimawr belimawr belimawr approved these changes

@ShourieG ShourieG ShourieG approved these changes

@strawgate strawgate Awaiting requested review from strawgate

+1 more reviewer

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chemamartinez chemamartinez

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[aws]Add support for access point in aws integration

7 participants

@chemamartinez @elasticmachine @AndersonQ @kaiyan-sheng @strawgate @belimawr @ShourieG