[Filebeat] [AWS] add support to source logs from AWS linked source accounts when using log_group_name_prefix#41206
Merged
Kavindu-Dodan merged 6 commits intoelastic:mainfrom Oct 15, 2024
Conversation
Contributor
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
6 tasks
Contributor
|
Just one comment for now: what do you think about the name |
Contributor
Author
Good suggestion, done with commit 3d3b46f |
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # x-pack/filebeat/input/awscloudwatch/input.go
3d3b46f to
2d0b247
Compare
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
2d0b247 to
4cd801e
Compare
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
kaiyan-sheng
approved these changes
Oct 15, 2024
belimawr
approved these changes
Oct 15, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
…counts when using log_group_name_prefix (#41206) * configuration parsing to support arn & linked accounts Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # x-pack/filebeat/input/awscloudwatch/input.go * code review change - fix typo Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add support to linked accounts when using prefix mode Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add changelog entry Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * review suggestion Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * use non-pointer struct property Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> --------- Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> (cherry picked from commit 7e1b528)
6 tasks
pierrehilbert
pushed a commit
that referenced
this pull request
Oct 15, 2024
…counts when using log_group_name_prefix (#41206) (#41247) * configuration parsing to support arn & linked accounts Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # x-pack/filebeat/input/awscloudwatch/input.go * code review change - fix typo Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add support to linked accounts when using prefix mode Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add changelog entry Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * review suggestion Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * use non-pointer struct property Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> --------- Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> (cherry picked from commit 7e1b528) Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
belimawr
pushed a commit
to belimawr/beats
that referenced
this pull request
Oct 18, 2024
…counts when using log_group_name_prefix (elastic#41206) * configuration parsing to support arn & linked accounts Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # x-pack/filebeat/input/awscloudwatch/input.go * code review change - fix typo Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add support to linked accounts when using prefix mode Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add changelog entry Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * review suggestion Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * use non-pointer struct property Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> --------- Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This is a follow-up to #41188 where I am adding support to source linked accounts when using
log_group_name_prefixto derive log groups.PR introduce
include_linked_accounts_for_prefix_modeboolean property, which is disabled by default. If enabled (include_linked_accounts_for_prefix_mode : true), then we setincludeLinkedAccountsproperty of the DescribeLogGroups API [1] to obtain log groups matching prefix and included in linked accounts of the monitoring account.ex:-
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
This require a linked cloudwatch account. If already has one, then,
CLOUDWATCH_LOG) [2]log_group_name_prefixwith desired prefix & setinclude_linked_accounts_for_prefix_modeto valuetrue(enabled)Related issues
[1] - https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_DescribeLogGroups.html
[2] - https://github.com/Kavindu-Dodan/data-gen