Add NewBeatReceiver function for beats as otel receivers by leehinman · Pull Request #40816 · elastic/beats

leehinman · 2024-09-13T14:57:02Z

Proposed commit message

This PR adds a new function NewBeatReceiver to instantiate a beat as an otel receiver. The code is similar to the createBeater and configure functions. It is separate to so that understanding of tel receivers doesn't leak into to existing Beat setup. This also makes it much safer to change the receiver setup without breaking the traditional beat setup.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None

Author's Checklist

[ ]

How to test this PR locally

Integration tests will catch if this change breaks regular beats instantiation. When receivers are added that will test that the new function works correctly.

Related issues

Closes Refactor Beat instantiation and setup #40659

Use cases

Screenshots

Logs

elasticmachine · 2024-09-13T14:57:19Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

mergify · 2024-09-13T14:57:38Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @leehinman? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

mergify · 2024-09-13T14:57:38Z

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

botelastic · 2024-09-13T14:58:14Z

This pull request doesn't have a Team:<team> label.

filebeat/input/input.go

go.mod

libbeat/beat/info.go

libbeat/cmd/instance/beat.go

go.mod

libbeat/cmd/instance/beat.go

cmacknz

I like this, thanks! I would like to make sure we have a test that creates a beat receiver with this method eventually, but I also recognize that requires a lot of work we haven't done yet.

* Add NewBeatReceiver function for beats as otel receivers (cherry picked from commit 8feb181)

…0891) * Add NewBeatReceiver function for beats as otel receivers (cherry picked from commit 8feb181) Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>

leehinman requested review from a team as code owners September 13, 2024 14:57

leehinman requested review from belimawr and mauri870 September 13, 2024 14:57

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 13, 2024

leehinman added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 13, 2024

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 13, 2024

mergify bot assigned leehinman Sep 13, 2024

mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 13, 2024

leehinman added needs_team Indicates that the issue/PR needs a Team:* label backport-skip Skip notification from the automated backport with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Sep 13, 2024

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 13, 2024

leehinman force-pushed the 40659_refactor_beat_instatiation branch from 510b9ed to 6fd0fee Compare September 13, 2024 15:23