Skip to content

[8.15](backport #40769) Do not cancel context on Connection.Close#40776

Merged
belimawr merged 1 commit into8.15from
mergify/bp/8.15/pr-40769
Sep 12, 2024
Merged

[8.15](backport #40769) Do not cancel context on Connection.Close#40776
belimawr merged 1 commit into8.15from
mergify/bp/8.15/pr-40769

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Sep 11, 2024 •
edited by zube bot
Loading

Proposed commit message

This commit removes a call to conn.cancelReqs() that causes the Connection to be unusable after Close() is called, leading to the bug described by #40705.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #40769 done by [Mergify](https://mergify.com).

@belimawr @mergify
Do not cancel context on Connection.Close (#40769)
6afd250 
This commit removes a call to conn.cancelReqs() that causes the
Connection to be unusable after Close() is called, leading to the bug
described by #40705.

(cherry picked from commit b0e4f85)
@mergify mergify bot added the backport label Sep 11, 2024
@mergify mergify bot requested a review from a team as a code owner September 11, 2024 23:17
@mergify mergify bot requested review from faec and leehinman and removed request for a team September 11, 2024 23:17
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 11, 2024
@jlind23 jlind23 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 12, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 12, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 12, 2024
@belimawr belimawr merged commit 2f0dda8 into 8.15 Sep 12, 2024
@belimawr belimawr deleted the mergify/bp/8.15/pr-40769 branch September 12, 2024 12:00
This was referenced Sep 20, 2024
Closed
Merged
cmacknz added a commit to cmacknz/beats that referenced this pull request Sep 24, 2024
@cmacknz
Add missing changelog for elastic#40776
b7100af
cmacknz added a commit that referenced this pull request Sep 25, 2024
@cmacknz
Add missing changelog for #40776 (#40976)
a09bd51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@belimawr belimawr

Labels

backport Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elasticmachine @VihasMakwana @belimawr @jlind23