Adding support for custom http headers and TLS for metricbeat modules#3945
Merged
ruflin merged 2 commits intoelastic:masterfrom Apr 7, 2017
Merged
Adding support for custom http headers and TLS for metricbeat modules#3945ruflin merged 2 commits intoelastic:masterfrom
ruflin merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
Contributor
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
66038ce to
f485795
Compare
Contributor
|
jenkins, test it |
ruflin
approved these changes
Apr 7, 2017
Contributor
ruflin
left a comment
There was a problem hiding this comment.
That is a great addition. It was already on my list to add headers and auth. What I really like about the PR is that it adds it all http based metricsets.
| // NewHTTP creates new http helper | ||
| func NewHTTP(base mb.BaseMetricSet) *HTTP { | ||
| config := struct { | ||
| TLS *outputs.TLSConfig `config:"ssl"` |
Contributor
There was a problem hiding this comment.
@urso as we start to using this in other places, we should probably move it out from the output package to ?
Contributor
ruflin
pushed a commit
to ruflin/beats
that referenced
this pull request
Apr 7, 2017
…elastic#3945) (cherry picked from commit 3f1c7c0)
tsg
pushed a commit
that referenced
this pull request
Apr 10, 2017
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Apr 12, 2017
…elastic#3945) (cherry picked from commit 3f1c7c0)
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Apr 12, 2017
…elastic#3945) (cherry picked from commit 3f1c7c0)
ruflin
pushed a commit
that referenced
this pull request
Apr 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to add TLS options when a user wants to hit HTTPS endpoints and also provide custom headers in case an endpoint has authentication enabled.
Example: