Skip to content

add equiv check to filebeat as shipper test#36536

Merged
leehinman merged 4 commits intoelastic:mainfrom
leehinman:doc_equivalence
Sep 12, 2023
Merged

add equiv check to filebeat as shipper test#36536
leehinman merged 4 commits intoelastic:mainfrom
leehinman:doc_equivalence

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

@leehinman leehinman commented Sep 8, 2023

Proposed commit message

add document equivalency check to filebeat as shipper process integration test

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run go integration tests

cd x-pack/filebeat
mage goUnitTest

Just run this test

cd x-pack/filebeat
mage docker:composeUp
go test ./tests/integration -count 1 -tags integration -run TestShipperInputOutput

Related issues

@leehinman leehinman added enhancement Team:Elastic-Agent Label for the Agent team labels Sep 8, 2023
@leehinman leehinman requested a review from a team as a code owner September 8, 2023 02:46
@leehinman leehinman requested review from belimawr and rdner September 8, 2023 02:46
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 8, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 8, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @leehinman? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 8, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-12T18:39:43.389+0000

  • Duration: 115 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 28265
Skipped 2013
Total 30278

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@leehinman leehinman requested a review from a team as a code owner September 8, 2023 15:28
belimawr
belimawr requested changes Sep 8, 2023
View reviewed changes
@leehinman
Copy link
Copy Markdown
Contributor Author

leehinman commented Sep 12, 2023

@cmacknz or @pierrehilbert can you review? I think the change to go.mod triggered a review by Beats Tech Leads

@leehinman leehinman merged commit ad2da2b into elastic:main Sep 12, 2023
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@leehinman @Scholar-Li
add equiv check to filebeat as shipper test (elastic#36536)
6dfcb2f 
* add equiv check to filebeat as shipper test

Closes elastic/elastic-agent-shipper#290

* update go.mod & NOTICE.txt

* fix unchecked error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@belimawr belimawr belimawr approved these changes

@cmacknz cmacknz cmacknz approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@leehinman leehinman

Labels

enhancement Team:Elastic-Agent Label for the Agent team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add document equivalency test case to end to end tests

4 participants

@leehinman @elasticmachine @belimawr @cmacknz