x-pack/filebeat/input/awss3: fix priority of region name configurations#36034
Merged
efd6 merged 2 commits intoelastic:mainfrom Jul 18, 2023
Merged
x-pack/filebeat/input/awss3: fix priority of region name configurations#36034efd6 merged 2 commits intoelastic:mainfrom
efd6 merged 2 commits intoelastic:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
This comment was marked as outdated.
This comment was marked as outdated.
The code currently prioritises the region_name configuration, even when it is not provided, against the claims of the documentation. Make a check whether it is empty before claiming a conflict and using it.
efd6
added a commit
that referenced
this pull request
Jul 18, 2023
…ns (#36034) (#36096) The code currently prioritises the region_name configuration, even when it is not provided, against the claims of the documentation. Make a check whether it is empty before claiming a conflict and using it. (cherry picked from commit 57d649d) Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com> Co-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com>
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
…ns (elastic#36034) The code currently prioritises the region_name configuration, even when it is not provided, against the claims of the documentation. Make a check whether it is empty before claiming a conflict and using it.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The code currently prioritises the region configuration, even when it is not provided, against the claims of the documentation. Make a check whether it is empty before claiming a conflict and using it.
Why is it important?
The behaviour disagrees with the documentation.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs