Removing pkg/errors from beats repo#35896
Conversation
|
This pull request doesn't have a |
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
| eventMap[eventKey] = &mb.Event{ | ||
| MetricSetFields: mapstr.M{}, | ||
| Error: errors.Wrapf(val.Err.Error, "failed on query=%v", counterPath), | ||
| Error: fmt.Errorf("failed on query=%v: %w", counterPath, val.Err.Error), |
| buildStr, errBufRead := ioutil.ReadAll(buildResp.Body) | ||
| if errBufRead != nil { | ||
| return errors.Wrap(err, "error reading from docker output") | ||
| return fmt.Errorf("error reading from docker output"+": %w", errBufRead) |
There was a problem hiding this comment.
@cmacknz note there was a bug originally here... logged err instead of errBufRead
|
|
||
| errReceived := runnable.Run(context.Background(), telemetry.Ignored()) | ||
| assert.Equal(t, err, e.Cause(errReceived)) | ||
| assert.Equal(t, "could not create a client for the function: "+err.Error(), errReceived.Error()) |
There was a problem hiding this comment.
special attention to this file
There was a problem hiding this comment.
If the tests still pass you're good, also this is functionbeat which is deprecated now.
|
/test |
efd6
left a comment
There was a problem hiding this comment.
There are "+" string concat scars from the gofmt rewrites, suggest running find . -name '*.go' -exec gsed -i -e 's/"+": %w",/: %w",/g' '{}' \; over the changes.
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
…ub.com/elastic/beats into remove_obsolete_error_package_entirely
efd6
left a comment
There was a problem hiding this comment.
Some minor nits, but otherwise LGTM.
| "net/url" | ||
| "testing" | ||
|
|
||
| _ "github.com/denisenkom/go-mssqldb" |
There was a problem hiding this comment.
Unrelated to the change here, but blank imports should generally be in their own stanza with a comment explaining the reason for their existence.
// For registration of "mssql" and "sqlserver" drivers.
_ "github.com/denisenkom/go-mssqldb"
It's odd that it's here given that "sql" is not being imported. Is it cruft? If it's not, maybe it should be in performance_integration_test.go which looks like it could be using it, maybe.
|
/test |
No description provided.