Skip to content

[DOCS] Clarify behavior of copy fields processor#34798

Merged
dedemorton merged 3 commits intoelastic:mainfrom
dedemorton:issue#33088
Apr 3, 2023
Merged

[DOCS] Clarify behavior of copy fields processor#34798
dedemorton merged 3 commits intoelastic:mainfrom
dedemorton:issue#33088

Conversation

@dedemorton
Copy link
Copy Markdown
Contributor

@dedemorton dedemorton commented Mar 10, 2023 •
edited
Loading

What does this PR do?

Makes it clear that user must drop or rename an existing field if they want to use copy_fields to replace the value.

This seems to be true based on the code here and some small tests I've run, but someone on the dev team needs to confirm the language.

The related issue also asks if conditions are supported. Since conditions are part of the processor syntax, I believe they are supported for all processors. Please confirm. On some pages, we show conditions in the example if the processor requires you to define a condition, so maybe that's the source of confusion.

Why is it important?

Users are confused.

Checklist

  • My code follows the style guidelines of this project

Related issues

@dedemorton dedemorton requested a review from a team as a code owner March 10, 2023 03:49
@dedemorton dedemorton self-assigned this Mar 10, 2023
@dedemorton dedemorton requested review from faec and ycombinator and removed request for a team March 10, 2023 03:49
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 10, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 10, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @dedemorton? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@dedemorton dedemorton added the Team:Docs Label for the Observability docs team label Mar 10, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 10, 2023

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 10, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 10, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-22T23:37:26.104+0000

  • Duration: 8 min 37 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert
Copy link
Copy Markdown
Contributor

pierrehilbert commented Mar 10, 2023

I think your correct, copy_fields apprends and not replace.
@kpollich I know you are not working on it anymore but could you confirm the behavior as you wrote it?

@pierrehilbert pierrehilbert requested review from kpollich and removed request for faec and ycombinator March 10, 2023 08:42
@kpollich
Copy link
Copy Markdown
Member

kpollich commented Mar 23, 2023

Hi @pierrehilbert - I do not know what this is referring to and I don't think I wrote anything regarding the copy_fields processor.

@pierrehilbert pierrehilbert requested review from pierrehilbert and removed request for kpollich March 27, 2023 16:55
@dedemorton dedemorton added backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Apr 3, 2023
@dedemorton dedemorton merged commit 25acf60 into elastic:main Apr 3, 2023
@dedemorton dedemorton deleted the issue#33088 branch April 3, 2023 20:43
mergify bot pushed a commit that referenced this pull request Apr 3, 2023
@dedemorton @mergify
Clarify behavior of copy fields processor (#34798)
7b06efb 
(cherry picked from commit 25acf60)
@mergify mergify bot mentioned this pull request Apr 3, 2023
Merged
mergify bot pushed a commit that referenced this pull request Apr 3, 2023
@dedemorton @mergify
Clarify behavior of copy fields processor (#34798)
23bcc99 
(cherry picked from commit 25acf60)
mergify bot pushed a commit that referenced this pull request Apr 3, 2023
@dedemorton @mergify
Clarify behavior of copy fields processor (#34798)
58a551d 
(cherry picked from commit 25acf60)
This was referenced Apr 3, 2023
Merged
Merged
dedemorton added a commit to elastic/observability-docs that referenced this pull request Apr 3, 2023
@dedemorton
Clarify behavior of copy fields processor
69a5cb2 
Adds changes from elastic/beats#34798 to the Elastic Agent processor docs
@dedemorton dedemorton mentioned this pull request Apr 3, 2023
Merged
dedemorton added a commit that referenced this pull request Apr 3, 2023
@mergify @dedemorton
Clarify behavior of copy fields processor (#34798) (#35003)
e14dd1a 
(cherry picked from commit 25acf60)

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
dedemorton added a commit that referenced this pull request Apr 3, 2023
@mergify @dedemorton
Clarify behavior of copy fields processor (#34798) (#35002)
a22cdd4 
(cherry picked from commit 25acf60)

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
dedemorton added a commit that referenced this pull request Apr 3, 2023
@mergify @dedemorton
Clarify behavior of copy fields processor (#34798) (#35001)
41c5da9 
(cherry picked from commit 25acf60)

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@dedemorton @chrisberkhout
Clarify behavior of copy fields processor (#34798)
dde773f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

Assignees

@dedemorton dedemorton

Labels

backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify docs Team:Docs Label for the Observability docs team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

copy_fields processor documentation not mentioning if it appends or replaces the value(s)

4 participants

@dedemorton @elasticmachine @pierrehilbert @kpollich