Prevent pipeline from queueing large batches before an output is set#34741
Merged
faec merged 8 commits intoelastic:mainfrom Mar 9, 2023
Merged
Prevent pipeline from queueing large batches before an output is set#34741faec merged 8 commits intoelastic:mainfrom
faec merged 8 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
rdner
reviewed
Mar 7, 2023
Member
rdner
left a comment
There was a problem hiding this comment.
I think we need tests for the new behaviour.
Contributor
Author
|
Tests added for both checks. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes to batch assembly in the pipeline:
eventConsumer, don't start assembling batches until we get a non-nil output channeloutputController, don't provideeventConsumerwith a non-nil output channel if the output list is empty.The first one prevents batches from being assembled while the output configuration is being updated. The second prevents batches from being assembled when running under Agent if we haven't yet received our output configuration. (When running under Agent, there is typically no output when
pipeline.Newis called, which previously allowed the construction of batches with no size limit before the output was really initialized.)Fixes #34703.
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.