Skip to content

filebeat/input/udp: fix inverted nil check logic#33920

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:st-5524-filebeat-fix
Dec 2, 2022
Merged

filebeat/input/udp: fix inverted nil check logic#33920
efd6 merged 1 commit intoelastic:mainfrom
efd6:st-5524-filebeat-fix

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Dec 1, 2022

What does this PR do?

This fixes an incorrect nil check that resulted from an incomplete test inversion during development.

Why is it important?

The current code causes a panic in the case that a metric is closed and reused.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 requested a review from a team December 1, 2022 23:36
@efd6 efd6 self-assigned this Dec 1, 2022
@efd6 efd6 requested a review from a team as a code owner December 1, 2022 23:36
@efd6 efd6 requested review from faec and rdner and removed request for a team December 1, 2022 23:36
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 1, 2022
@botelastic
Copy link
Copy Markdown

botelastic bot commented Dec 1, 2022

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 1, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @efd6? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@efd6 efd6 mentioned this pull request Dec 1, 2022
Merged
6 tasks
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-01T23:37:06.657+0000

  • Duration: 84 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 7133
Skipped 738
Total 7871

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 merged commit cc0093d into elastic:main Dec 2, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @chrisberkhout
filebeat/input/udp: fix inverted nil check logic (#33920)
7e6f7b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels

8.7-candidate bug Filebeat Filebeat needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6 @elasticmachine @andrewkroh