[Filebeat] lumberjack - refactor loop logic into method#33071
Merged
andrewkroh merged 1 commit intoelastic:mainfrom Sep 14, 2022
Merged
[Filebeat] lumberjack - refactor loop logic into method#33071andrewkroh merged 1 commit intoelastic:mainfrom
andrewkroh merged 1 commit intoelastic:mainfrom
Conversation
Move the batch processing logic contained with the lumberjack server into its own method. The closure passed to newBatchACKTracker referenced the loop variable whose value would change on each iteration. This resulted in incorrect ACKing behavior.
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Merged
4 tasks
efd6
approved these changes
Sep 14, 2022
Contributor
|
Can you paste an example panic here? |
Member
Author
|
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Move the batch processing logic contained with the lumberjack server into its own method. The closure passed to newBatchACKTracker referenced the loop variable whose value would change on each iteration. This resulted in incorrect ACKing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move the batch processing logic contained with the lumberjack server into its own method.
The closure passed to
newBatchACKTrackerreferenced the loop variable (line 84) whose value would change on each iteration. This resulted in incorrect ACKing behavior. This is a fix for a new unreleased input targeting v8.5.0 hence no changelog or backport.beats/x-pack/filebeat/input/lumberjack/server.go
Lines 70 to 84 in c293fbd
Why is it important?
Any concurrent batch processing can result in incorrect behavior or panics.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Unit testing didn't expose this since it requires multiple concurrent batches. My test strategy was to run three filebeats. One receiving data on 5044. And two others sending batches and exiting.
while [ true ]; do gtimeout 5 ./filebeat -e -c ./filebeat.logstash.yml --path.data=data1; rm -rf data; donewhile [ true ]; do gtimeout 5 ./filebeat -e -c ./filebeat.logstash.yml --path.data=data2; rm -rf data; doneRelated issues