Skip to content

[AWS CloudTrail] use json.digestS3Object for file.path#32759

Merged
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:cloudtrail_field
Aug 23, 2022
Merged

[AWS CloudTrail] use json.digestS3Object for file.path#32759
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:cloudtrail_field

Conversation

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng commented Aug 22, 2022 •
edited
Loading

What does this PR do?

This PR is to fix a bug in CloudTrail fileset ingest pipeline: instead of json.previousDigestS3Object, we should use json.digestS3Object for file.path.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

closes #32609

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner August 22, 2022 18:36
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 22, 2022
@kaiyan-sheng kaiyan-sheng self-assigned this Aug 22, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 22, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaiyan-sheng? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@kaiyan-sheng kaiyan-sheng added backport-7.17 Automated backport to the 7.17 branch with mergify Team:Cloud-Monitoring Label for the Cloud Monitoring team backport-v8.4.0 Automated backport with mergify labels Aug 22, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 22, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 22, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-22T21:00:51.720+0000

  • Duration: 134 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 4399
Skipped 338
Total 4737

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tommyers-elastic
Copy link
Copy Markdown
Contributor

tommyers-elastic commented Aug 23, 2022

is there an issue for this?

@kaiyan-sheng
Copy link
Copy Markdown
Contributor Author

kaiyan-sheng commented Aug 23, 2022

@tommyers-elastic Yep I just linked the issue.

@kaiyan-sheng kaiyan-sheng merged commit e54ab4e into elastic:main Aug 23, 2022
@kaiyan-sheng kaiyan-sheng deleted the cloudtrail_field branch August 23, 2022 14:12
mergify bot pushed a commit that referenced this pull request Aug 23, 2022
@mergify
[AWS CloudTrail] use json.digestS3Object for file.path (#32759)
6471754 
(cherry picked from commit e54ab4e)
@mergify mergify bot mentioned this pull request Aug 23, 2022
Merged
mergify bot pushed a commit that referenced this pull request Aug 23, 2022
@mergify
[AWS CloudTrail] use json.digestS3Object for file.path (#32759)
1dc768a 
(cherry picked from commit e54ab4e)
@mergify mergify bot mentioned this pull request Aug 23, 2022
Merged
kaiyan-sheng pushed a commit that referenced this pull request Aug 23, 2022
@mergify
[AWS CloudTrail] use json.digestS3Object for file.path (#32759) (#32776)
2ded7e3 
(cherry picked from commit e54ab4e)

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
kaiyan-sheng pushed a commit that referenced this pull request Aug 24, 2022
@mergify
[AWS CloudTrail] use json.digestS3Object for file.path (#32759) (#32777)
6fcaa8a 
(cherry picked from commit e54ab4e)

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@chrisberkhout
[AWS CloudTrail] use json.digestS3Object for file.path (#32759)
010b5e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.4.0 Automated backport with mergify Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filebeat ingest processor for CloudTrail maps previous digest object

3 participants

@kaiyan-sheng @elasticmachine @tommyers-elastic