Add benchmark for beats->protobuf/shipper event conversion#32273
Merged
rdner merged 3 commits intoelastic:mainfrom Jul 11, 2022
Merged
Add benchmark for beats->protobuf/shipper event conversion#32273rdner merged 3 commits intoelastic:mainfrom
rdner merged 3 commits intoelastic:mainfrom
Conversation
This is to detect future regressions when a change is made to the conversion function.
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Member
|
Out of curiosity what are the benchmark results? |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Member
Author
|
@cmacknz I don't think it's correct to look at absolute numbers but here is what I have on my |
cmacknz
approved these changes
Jul 8, 2022
efd6
reviewed
Jul 10, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
This is to detect future regressions when a change is made to the conversion function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is to detect future regressions when a change is made to the
conversion function.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues