Skip to content

Migrate to elastic-agent-shipper-client#32185

Merged
rdner merged 1 commit intoelastic:mainfrom
rdner:use-shipper-client
Jul 6, 2022
Merged

Migrate to elastic-agent-shipper-client#32185
rdner merged 1 commit intoelastic:mainfrom
rdner:use-shipper-client

Conversation

@rdner
Copy link
Copy Markdown
Member

@rdner rdner commented Jul 4, 2022 •
edited
Loading

What does this PR do?

So, we stop copying the package to Beats and use a shared package instead.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@rdner rdner self-assigned this Jul 4, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 4, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 4, 2022 •
edited by jenkins-beats-ci bot
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-05T19:48:18.758+0000

  • Duration: 120 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 22405
Skipped 1937
Total 24342

Steps errors 2

Expand to view the steps failures

metricbeat-goIntegTest - mage goIntegTest
  • Took 30 min 30 sec . View more details here
  • Description: mage goIntegTest
Building Beats » Beats Packaging » PR-32185
  • Took 31 min 57 sec . View more details here
  • Description: null

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@rdner rdner force-pushed the use-shipper-client branch 2 times, most recently from a79dc31 to ee25b9b Compare July 5, 2022 14:56
@rdner
Copy link
Copy Markdown
Member Author

rdner commented Jul 5, 2022

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 5, 2022

update

✅ Branch has been successfully updated

@rdner
Copy link
Copy Markdown
Member Author

rdner commented Jul 5, 2022

@cmacknz I might have to wait until #32161 is merged, I have the same failures after updating elastic-agent-libs to v0.2.7

@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Jul 5, 2022

The tests are passing in #32161, just needs an approval. Feel free to merge it yourself if needed.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 5, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b use-shipper-client upstream/use-shipper-client
git merge upstream/main
git push upstream use-shipper-client

@rdner
Migrate to elastic-agent-shipper-client
97f42f3 
So, we stop copying the package to Beats and use a shared package instead.
@rdner rdner force-pushed the use-shipper-client branch from 80525bc to 97f42f3 Compare July 5, 2022 19:47
@rdner
Copy link
Copy Markdown
Member Author

rdner commented Jul 6, 2022

Packaging errors are not related to the change.

@rdner rdner marked this pull request as ready for review July 6, 2022 07:03
@rdner rdner requested a review from a team as a code owner July 6, 2022 07:03
@rdner rdner requested review from faec and leehinman and removed request for a team July 6, 2022 07:03
@rdner rdner added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jul 6, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 6, 2022

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 6, 2022
@rdner rdner merged commit 51c8eda into elastic:main Jul 6, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@rdner @chrisberkhout
Migrate to elastic-agent-shipper-client (#32185)
dff88f7 
So, we stop copying the package to Beats and use a shared package instead.
@rdner rdner deleted the use-shipper-client branch November 1, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmacknz cmacknz cmacknz approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@rdner rdner

Labels

enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow the Beats' shipper output to depend on the shipper client directly.

3 participants

@rdner @elasticmachine @cmacknz