Skip to content

Revert "ci: e2e-testing should fail the build (#31135)"#32079

Merged
cmacknz merged 1 commit intoelastic:mainfrom
cmacknz:remove-e2e-dra-gate
Jun 23, 2022
Merged

Revert "ci: e2e-testing should fail the build (#31135)"#32079
cmacknz merged 1 commit intoelastic:mainfrom
cmacknz:remove-e2e-dra-gate

Conversation

@cmacknz
Copy link
Copy Markdown
Member

@cmacknz cmacknz commented Jun 23, 2022

This reverts commit 2241413.

Allow the E2E tests to keep running but do not have them fail the build when they do not pass.

Part of #32076. The E2E tests are not reliable enough to act as a quality gate for the DRA process yet. The team doesn't have the capacity to improve the tests fast enough. We previously went 2+ weeks without publishing a beats snapshot image.

This reverts commit 2241413.

Allow the E2E tests to keep running but not fail the build when they
fail while we work to stabilize them:
elastic#32076
@cmacknz cmacknz added ci Team:Automation Label for the Observability productivity team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jun 23, 2022
@cmacknz cmacknz requested a review from a team as a code owner June 23, 2022 18:30
@cmacknz cmacknz self-assigned this Jun 23, 2022
@cmacknz cmacknz requested review from belimawr and fearful-symmetry and removed request for a team June 23, 2022 18:30
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 23, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 23, 2022
@cmacknz cmacknz requested review from joshdover and v1v June 23, 2022 18:32
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-23T18:31:05.374+0000

  • Duration: 17 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz cmacknz merged commit ef6096f into elastic:main Jun 23, 2022
@cmacknz cmacknz deleted the remove-e2e-dra-gate branch June 23, 2022 18:48
@v1v
Copy link
Copy Markdown
Member

v1v commented Jun 23, 2022

No please, this change could be reverted and used:

          propagate: false,
          wait: false)

Then this will run async and without waiting for the outcome

The catchError with the propagate is not needed IMO

@cmacknz
Copy link
Copy Markdown
Member Author

cmacknz commented Jun 23, 2022

That sounds better, I'll open a follow up PR.

@cmacknz
Copy link
Copy Markdown
Member Author

cmacknz commented Jun 23, 2022

#32080

cmacknz added a commit to cmacknz/beats that referenced this pull request Jun 23, 2022
Ignore the result while flaky and unstable tests are fixed.

Follow up from elastic#32079
cmacknz added a commit that referenced this pull request Jun 23, 2022
Ignore the result while flaky and unstable tests are fixed.

Follow up from #32079
@v1v v1v added the backport-v8.3.0 Automated backport with mergify label Jul 4, 2022
mergify bot pushed a commit that referenced this pull request Jul 4, 2022
This reverts commit 2241413.

Allow the E2E tests to keep running but not fail the build when they
fail while we work to stabilize them:
#32076

(cherry picked from commit ef6096f)
v1v pushed a commit that referenced this pull request Jul 4, 2022
Ignore the result while flaky and unstable tests are fixed.

Follow up from #32079
@rdner rdner added the backport-7.17 Automated backport to the 7.17 branch with mergify label Oct 13, 2022
mergify bot pushed a commit that referenced this pull request Oct 13, 2022
This reverts commit 2241413.

Allow the E2E tests to keep running but not fail the build when they
fail while we work to stabilize them:
#32076

(cherry picked from commit ef6096f)
rdner pushed a commit that referenced this pull request Oct 13, 2022
)

This reverts commit 2241413.

Allow the E2E tests to keep running but not fail the build when they
fail while we work to stabilize them:
#32076

(cherry picked from commit ef6096f)

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
This reverts commit 2241413.

Allow the E2E tests to keep running but not fail the build when they
fail while we work to stabilize them:
#32076
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
Ignore the result while flaky and unstable tests are fixed.

Follow up from #32079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.3.0 Automated backport with mergify ci Team:Automation Label for the Observability productivity team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants