[7.17](backport elastic/elastic-agent#570) Add filemod times to contents of diagnostics collect command#31986
Merged
ph merged 2 commits intoelastic:7.17from Jun 22, 2022
Merged
Conversation
…diagnostics collect command * Add filemod times to contents of diagnostics collect command Add filemod times to the files and directories in the zip archive. Log files (and sub dirs) will use the modtime returned by the fileinfo for the source. Others will use the timestamp from when the zip is created. * Fix linter
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
ph
approved these changes
Jun 20, 2022
Contributor
ph
left a comment
There was a problem hiding this comment.
change lgtm.
I will rekick the test, looking at the error at packaging this seems to be an ansible playbook issues.
Contributor
|
test this please |
Contributor
Author
|
/package |
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
ph
approved these changes
Jun 22, 2022
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…nts of diagnostics collect command (elastic#31986) * [7.17](backport #elastic-agent/570) Add filemod times to contents of diagnostics collect command * Add filemod times to contents of diagnostics collect command Add filemod times to the files and directories in the zip archive. Log files (and sub dirs) will use the modtime returned by the fileinfo for the source. Others will use the timestamp from when the zip is created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport elastic/elastic-agent#570
Add filemod times to the files and directories in the zip archive.
Log files (and sub dirs) will use the modtime returned by the fileinfo
for the source. Others will use the timestamp from when the zip is
created.