winlogbeat: disentangle test data from x-pack/winlogbeat#31858
Merged
efd6 merged 1 commit intoelastic:mainfrom Jun 9, 2022
Merged
winlogbeat: disentangle test data from x-pack/winlogbeat#31858efd6 merged 1 commit intoelastic:mainfrom
efd6 merged 1 commit intoelastic:mainfrom
Conversation
9 tasks
This makes the test data local to the testing code rather than reaching across the filesystem. Also make some testing helpers more informative.
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
andrewkroh
approved these changes
Jun 9, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
This makes the test data local to the testing code rather than reaching across the filesystem. Also make some testing helpers more informative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes the test data local to the testing code rather than reaching across the
filesystem. Also make some testing helpers more informative.
Why is it important?
The movement of test data in #31817 broke the tests here. This was not discovered until running tests in #31833 due to the non-locality of the data. The duplication of the data here fixes the tests and helps to prevent another case of this kind of breakage.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs