Make the queue's public API accept interface{} instead of publisher.Event#31699
Merged
faec merged 12 commits intoelastic:mainfrom May 26, 2022
Merged
Make the queue's public API accept interface{} instead of publisher.Event#31699faec merged 12 commits intoelastic:mainfrom
faec merged 12 commits intoelastic:mainfrom
Conversation
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
cmacknz
reviewed
May 20, 2022
Contributor
Author
|
This is ready for review now (the tests pass, locally at least) |
fearful-symmetry
approved these changes
May 23, 2022
Contributor
fearful-symmetry
left a comment
There was a problem hiding this comment.
So, my LGTM is limited to the memqueue, since that's really the only part I understand, but it looks fine.
cmacknz
approved these changes
May 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Finishes the refactor started in #31356, modifying the public queue API to accept and return
interface{}pointers rather thanpublisher.Event, which will allow the new elastic shipper to use the libbeat queue for its internal storage.Closes #31307
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.