Skip to content

ci: notify only when builds for branches/tags have failed #30802

Merged
v1v merged 2 commits intoelastic:mainfrom
v1v:feature/notify-beats-slack
Mar 14, 2022
Merged

ci: notify only when builds for branches/tags have failed #30802
v1v merged 2 commits intoelastic:mainfrom
v1v:feature/notify-beats-slack

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Mar 14, 2022 •
edited
Loading

What does this PR do?

Update the slack channel to a more widely one.

Why is it important?

@jlind23 asked to update this channel and when

we should then act quickly and investigate if a nightly build is failing, that's something to be done by the Beats teams, am I correct? There is a slack channel #beats-build that notifies the builds for each branch.

@v1v I do not see this channel as being widely used. Can we rather have a notification in the beats channel when it's failing only?

As requested let's use a different slack channel.

@v1v v1v added automation Team:Automation Label for the Observability productivity team backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Mar 14, 2022
@v1v v1v requested review from cmacknz, jlind23 and ph March 14, 2022 15:47
@v1v v1v requested a review from a team as a code owner March 14, 2022 15:47
@v1v v1v self-assigned this Mar 14, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 14, 2022
@cachedout
Copy link
Copy Markdown
Contributor

cachedout commented Mar 14, 2022

@v1v For the sake of completeness, could you please update the body of this to mention who specifically requested this?

v1v
v1v commented Mar 14, 2022
View reviewed changes
Jenkinsfile
dir("${BASE_DIR}"){
notifyBuildResult(prComment: true,
slackComment: true, slackNotify: (isBranch() || isTag()),
slackComment: true,
Copy link
Copy Markdown
Member Author

@v1v v1v Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default behaviour honours builds for branches/tags which failed.

https://github.com/elastic/apm-pipeline-library/blob/53d5532084be9f9ea4e6425bc3fe165fa6e9ab90/vars/notifyBuildResult.groovy#L65

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 14, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-14T15:56:13.789+0000

  • Duration: 99 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 43028
Skipped 3874
Total 46902

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

jlind23
jlind23 approved these changes Mar 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@v1v v1v changed the title ci: notify build status in slack ci: notify only when builds for branches/tags have failed Mar 14, 2022
@v1v v1v merged commit c526996 into elastic:main Mar 14, 2022
@v1v v1v deleted the feature/notify-beats-slack branch March 14, 2022 19:01
mergify bot pushed a commit that referenced this pull request Mar 14, 2022
@v1v
ci: notify only when builds for branches/tags have failed (#30802)
77bb3aa 
(cherry picked from commit c526996)
@mergify mergify bot mentioned this pull request Mar 14, 2022
Merged
mergify bot pushed a commit that referenced this pull request Mar 14, 2022
@v1v
ci: notify only when builds for branches/tags have failed (#30802)
e2353de 
(cherry picked from commit c526996)
@mergify mergify bot mentioned this pull request Mar 14, 2022
Merged
v1v pushed a commit that referenced this pull request Mar 15, 2022
@mergify
ci: notify only when builds for branches/tags have failed (#30802) (#…
1a24fd7 
…30814)
v1v pushed a commit that referenced this pull request Mar 15, 2022
@mergify
ci: notify only when builds for branches/tags have failed (#30802) (#…
5351560 
…30813)
@v1v v1v added the backport-v8.0.0 Automated backport with mergify label Mar 17, 2022
mergify bot pushed a commit that referenced this pull request Mar 17, 2022
@v1v
ci: notify only when builds for branches/tags have failed (#30802)
1522519 
(cherry picked from commit c526996)
@mergify mergify bot mentioned this pull request Mar 17, 2022
Merged
v1v added a commit that referenced this pull request Mar 17, 2022
@mergify @v1v
ci: notify only when builds for branches/tags have failed (#30802) (#…
bdf131a 
…30900)

(cherry picked from commit c526996)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@mergify @v1v
ci: notify only when builds for branches/tags have failed (elastic#30802
31ac99f 
) (elastic#30900)

(cherry picked from commit fb35653)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cachedout cachedout cachedout approved these changes

@jlind23 jlind23 jlind23 approved these changes

@ph ph Awaiting requested review from ph

@cmacknz cmacknz Awaiting requested review from cmacknz

Assignees

@v1v v1v

Labels

automation backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify Team:Automation Label for the Observability productivity team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@v1v @cachedout @elasticmachine @jlind23