Skip to content

cloudbeat libbeat changes#30699

Merged
cmacknz merged 5 commits intomainfrom
unknown repository
Mar 9, 2022
Merged

cloudbeat libbeat changes#30699
cmacknz merged 5 commits intomainfrom
unknown repository

Conversation

@oren-zohar
Copy link
Copy Markdown
Contributor

@oren-zohar oren-zohar commented Mar 6, 2022 •
edited
Loading

What does this PR do?

  • Adds more types of Kubernetes resources to libbeat, used by cloudbeat

Why is it important?

As part of the Cloud Security Posture team work to add our own beat to collect cloud posture information and send it to ES, cloudbeat consumes more unsupported Kubernetes types.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

oren-zohar and others added 3 commits February 28, 2022 12:06
@oren-zohar @amirbenun
@eyalkraft @ofiriro3 @DaveSys911 @uri-weisman
first draft - agent changes for cloudbeat
76423e9 
Co-authored-by: Amir Ben Nun <amir.bennun@elastic.co>
Co-authored-by: Yash Tewari <yash.tewari@elastic.co>
Co-authored-by: Eyal Kraft <eyal.kraft@elastic.co>
Co-authored-by: Ofir Lapid <ofir.lapid@elastic.co>
Co-authored-by: Oren Zohar <oren.zohar@elastic.co>
Co-authored-by: David Natchanny <david.natachanny@elastic.co>
Co-authored-by: Uri Weisman <uri.weisman@elastic.co>
@oren-zohar
exclude cloudbeat from build
f401bf2
@oren-zohar
skip_on_missing
4943c5f
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 6, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 6, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 6, 2022

This pull request does not have a backport label. Could you fix it @oren-zohar? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 6, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 6, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview [preview](https://ci-stats.elastic.co/app/apm/services/beats-ci/transactions/view?rangeFrom=2022-03-07T18:14:27.152Z&rangeTo=2022-03-07T18:34:27.152Z&transactionName=BUILD Beats/beats/PR-{number}&transactionType=job&latencyAggregationType=avg&traceId=87378e6e7a86929e0866a9bc5d8380e5&transactionId=9e812d1b569cc7b0)

Expand to view the summary

Build stats

  • Start Time: 2022-03-07T18:24:27.152+0000

  • Duration: 122 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 42999
Skipped 3846
Total 46845

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@oren-zohar oren-zohar marked this pull request as ready for review March 7, 2022 10:00
@oren-zohar oren-zohar requested review from a team as code owners March 7, 2022 10:01
@ph
Copy link
Copy Markdown
Contributor

ph commented Mar 7, 2022

This PR will need to be split into more than one.

We just have extracted elastic-agent into his own repository elastic at https://github.com/elastic/elastic-agent
@cmacknz concerning the libbeat changes should they still target this repository?

@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Mar 7, 2022 •
edited
Loading

@cmacknz concerning the libbeat changes should they still target this repository?

The libbeat changes can still target this repository for now. We are working on creating a repository for autodiscovery that will include Kubernetes but it isn't ready yet.

@oren-zohar oren-zohar mentioned this pull request Mar 7, 2022
Merged
6 tasks
@oren-zohar oren-zohar requested a review from a team as a code owner March 7, 2022 18:24
@oren-zohar oren-zohar changed the title Add Cloudbeat support to the agent cloudbeat libbeat changes Mar 7, 2022
@oren-zohar
Copy link
Copy Markdown
Contributor Author

oren-zohar commented Mar 7, 2022

@ph @cmacknz opened a separated PR for the agent changes, left only the relevant libbeat changes in this PR.

@cmacknz cmacknz added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Mar 7, 2022
@cmacknz cmacknz requested review from ChrsMark and removed request for a team March 7, 2022 19:13
@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Mar 7, 2022

@ChrsMark can you sanity check this? I see your name in the commit log for these k8s files. Feel free to assign a better reviewer if there is one.

@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Mar 8, 2022

Thanks! For reference the future home of this code will be https://github.com/elastic/elastic-agent-autodiscover (not ready yet).

kvch added a commit to kvch/elastic-agent-autodiscover that referenced this pull request Mar 8, 2022
@kvch
pick changes from elastic/beats#30699
2d384e4
@cmacknz cmacknz merged commit 12977c7 into elastic:main Mar 9, 2022
@oren-zohar oren-zohar deleted the cloudbeat-changes branch March 9, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmacknz cmacknz cmacknz approved these changes

@ChrsMark ChrsMark Awaiting requested review from ChrsMark

Assignees

@oren-zohar oren-zohar

Labels

backport-skip Skip notification from the automated backport with mergify enhancement Team:Cloud-Security-Posture The CSP team Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oren-zohar @elasticmachine @ph @cmacknz